Fix a few bugs #2126
Merged
Fix a few bugs #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
reviewed
Aug 21, 2020
src/DataGrid.tsx
Outdated
Comment on lines
287
to
289
| const formatterOptions = columns[selectedPosition.idx]?.formatterOptions; | ||
| const row = rows[selectedPosition.rowIdx]; | ||
| if ((typeof formatterOptions?.focusable === 'function' && formatterOptions?.focusable(row)) || formatterOptions?.focusable === true) { |
There was a problem hiding this comment.
Suggested change
| const formatterOptions = columns[selectedPosition.idx]?.formatterOptions; | |
| const row = rows[selectedPosition.rowIdx]; | |
| if ((typeof formatterOptions?.focusable === 'function' && formatterOptions?.focusable(row)) || formatterOptions?.focusable === true) { | |
| const focusable = columns[selectedPosition.idx]?.formatterOptions?.focusable; | |
| if ((typeof focusable === 'function' && focusable(rows[selectedPosition.rowIdx])) || focusable === true) { |
wdyt?
nstepien
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enterif the value is not changeddefaultSortableformatterOptions.focusableto a function so different rows can have different focus behavior