Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove formatterOptions #2138

Merged
merged 5 commits into from
Sep 1, 2020
Merged

Remove formatterOptions #2138

merged 5 commits into from
Sep 1, 2020

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 commented Aug 31, 2020

onFocus bubbles so we can use it to check if a cell was focused or not. This behavior is not changing in react 17. We won't need special handling for group row cells and conditional focusing

https://reactjs.org/blog/2020/08/10/react-v17-rc.html#aligning-with-browsers

@amanmahajan7 amanmahajan7 self-assigned this Aug 31, 2020
@amanmahajan7 amanmahajan7 marked this pull request as ready for review August 31, 2020 18:05
nstepien
nstepien previously approved these changes Sep 1, 2020
src/Row.tsx Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
@amanmahajan7 amanmahajan7 merged commit c2adb22 into canary Sep 1, 2020
@amanmahajan7 amanmahajan7 deleted the am-cell-focus branch September 1, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants