Only make scrollToRow smooth #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit acee66f.
amanmahajan7
reviewed
Nov 2, 2020
| @@ -354,7 +354,10 @@ function DataGrid<R, SR>({ | |||
| scrollToRow(rowIdx: number) { | |||
| const { current } = gridRef; | |||
| if (!current) return; | |||
| current.scrollTop = rowIdx * rowHeight; | |||
| current.scrollTo({ | |||
There was a problem hiding this comment.
Does it work in safari
https://caniuse.com/?search=scrollTo
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/API/ScrollToOptions
ScrollToOptions is supported, but the smooth option isn't supported yet so it'll be ignored.
Last modified: Aug 21, 2019
The mdn page hasn't been updated for over a year so it's probably safe to use this.
amanmahajan7
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scroll-behavior: smooth;made all scrolling smooth, including keyboard navigation, which is probably not desirable, especially when holding arrow keys.I've made it so only
scrollToRowis smooth.