Fix "click outside + immediate editor commit" edge case by swiching to checking for mousedown events #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o checking for mousedown events
Codecov Report
@@ Coverage Diff @@
## canary #2415 +/- ##
==========================================
- Coverage 70.50% 70.50% -0.01%
==========================================
Files 39 39
Lines 3618 3617 -1
Branches 316 316
==========================================
- Hits 2551 2550 -1
Misses 1067 1067
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2414
I had also tried to fix this by adding an extra "sync" check on the bubble phase of the
clickevent, but that wouldn't work as theclickon the external save button would happen first, and thus wouldn't get the updated state.