Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fixes #114

Merged
merged 4 commits into from
Dec 11, 2020
Merged

Various small fixes #114

merged 4 commits into from
Dec 11, 2020

Conversation

mfherbst
Copy link
Member

@mfherbst mfherbst commented Dec 11, 2020

Note: Coverage drops because previously the coverage of the C++ test files themselves was also reported, which does not make that much sense in my opinion.

@lgtm-com
Copy link

lgtm-com bot commented Dec 11, 2020

This pull request fixes 2 alerts when merging 1a41b6d into e674477 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

@mfherbst
Copy link
Member Author

Feel free to merge @maxscheurer.

@lgtm-com
Copy link

lgtm-com bot commented Dec 11, 2020

This pull request fixes 2 alerts when merging 9b0f74c into 13be939 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

@mfherbst mfherbst merged commit f74ca6b into master Dec 11, 2020
@mfherbst mfherbst deleted the small-fixes branch December 11, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants