Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Total matched invoice qty #3462

Closed
e-Evolution opened this issue May 21, 2021 · 2 comments · Fixed by #3464
Closed

[Bug Report] Total matched invoice qty #3462

e-Evolution opened this issue May 21, 2021 · 2 comments · Fixed by #3464

Comments

@e-Evolution
Copy link
Contributor

e-Evolution commented May 21, 2021

Bug report

Error match invoice duplicates the record for receipt of material and invoice

when reversals were enabled for match invoice or match purchase order the three-way validation purchase order -> material receipt, material order receipt -> invoice now requires recording each match independently for each document compared to the previous approach where a single record was used to match receipt and invoice.

Steps to reproduce

1.- Create a new invoice
2.- Create lines based on the purchase order

Screenshot or Gif

image

image

Expected behavior

Only should be a record for match purchase should be created

Other relevant information

  • Your OS: macos
  • Java version: 1.8
  • ADempiere version: 3.9.3
  • Browser safari
  • DB Provider: PG
  • DB version: 11.2
@e-Evolution e-Evolution self-assigned this May 21, 2021
@e-Evolution e-Evolution added this to the 3.9.4 milestone May 21, 2021
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue May 21, 2021
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue May 21, 2021
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue May 21, 2021
@yamelsenih
Copy link
Member

Please can you add a step by step for reproduce this bug?

The above steps is not completed for reproduce.
I want to reproduce the big completely

Best regards

@e-Evolution
Copy link
Contributor Author

e-Evolution commented May 23, 2021

Steps to reproduce

1.- Create a new Purchase Order

image

2.- Adding line Mulch by 500 Each

image

3.- Create a Material Receipt by partial quantity in this case 100 each

image

4.- Create other Material Receipt by 10 each

image

5.- Generate the Invoice lines based on the Purchase Order

image

Here the system magically matches the first receipt it finds, when it shouldn't since the match is with the purchase order, not with the material receipt.

But the problem is generated when I generate the second invoice for the same purchase order because it was a partial delivery.

The current logic creates a match of this invoice with the same receipt that was already matched causing a huge inconsistency.

Even when a purchase order has multiple receipts and invoices, this is very difficult to fix, since all the invoices created from the purchase order are matched with the same receipt, which is completely incorrect.

This is what the legacy code does today that is why this logic was removed, as it is incorrect.

On the other hand, an invoice that is created from the purchase order should only create a match with the purchase order.

e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Jun 28, 2021
* develop: (63 commits)
  Fixed error with Dependent Entities for Record Access (adempiere#3480)
  Remove deprecated methods for Order (adempiere#3484)
  Fixed error when a Purchase order is voided (adempiere#3449)
  adempiere#3469 [Bug Report] In the process Generate an Invoice from the Receipt is not validate if an Invoice was generated adempiere#3469 (adempiere#3470)
  adempiere#3467 [Bug Report] Generate Receipt from Invoice process is not validate if was generate a Material Receipt from a previous execution adempiere#3467 (adempiere#3468)
  adempiere#3462 [Bug Report] Total matched invoice qty adempiere#3462 (adempiere#3464)
  Improve Standard Request Type (adempiere#3453)
  Revert "adempiere#3266 Error in calculating quantity ordered or reserved for Sales Order, manufacturing order and distribution order adempiere#3266"
  Update IT_Query to be more robust in the case where there are multiple clients in the database.  The previous tests assumed the seed was being used for the test which may not always be correct. (+1 squashed commits)
  adempiere#3465 [Bug Report] Error when try delete a material receipt created from Invoice adempiere#3465
  Add support to included role for ASP This pull request allows merge the ASP for a role when this is part of other role as include roles
  Fix parent link
  Fixed error with parent link for W_Category
  Add some columns for RV_C_RFQResponse
  Fixed wrong search for concept acct When a **Payroll Process** is processed and is create facts, the account from concept is created based on Account Schema, payroll of process and business partner group.
  Add Purchasing Tab to Business Partner
  Fixed error with Import ARXML of Print format When a print format is header and line like is **Invoice Header** and the print format is exported as .arxml format. The definition is exported but when is imported in other ADempiere instance the lines are missing.
  Fixed error with NPE for system reports When a print format is created from system and called from a company is throwed a error NPE:
  Update release.yml
  Update ExportReference.sh
  ...

# Conflicts:
#	base/src/org/compiere/model/MOrder.java
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Jul 1, 2021
* develop: (29 commits)
  Add overwrite values from Smart Browser field
  Allows define system events for validation of Standard Request Type
  Validate client
  Add better approach for validation engine
  Add optional value for source price list
  Add support to data type as mapping from entities (adempiere#3476)
  Adding the Weight and Volume field into Sales Order and Purchase Order  Feature/3473 (adempiere#3474)
  Add the database function to get the daily salary (adempiere#3458)
  Error in calculating quantity ordered or reserved for manufacturing order and distribution order  (adempiere#3472)
  Fixed error with missing parameter for Requisition PO Create (adempiere#3475)
  Fixed error with Dependent Entities for Record Access (adempiere#3480)
  Remove deprecated methods for Order (adempiere#3484)
  Fixed error when a Purchase order is voided (adempiere#3449)
  Update MPPForecastDefinitionLine.java
  adempiere#3469 [Bug Report] In the process Generate an Invoice from the Receipt is not validate if an Invoice was generated adempiere#3469 (adempiere#3470)
  adempiere#3467 [Bug Report] Generate Receipt from Invoice process is not validate if was generate a Material Receipt from a previous execution adempiere#3467 (adempiere#3468)
  adempiere#3462 [Bug Report] Total matched invoice qty adempiere#3462 (adempiere#3464)
  Fixed error with translation value for reference
  fix: BP Group getSQlWhere in Forecast Run Create.
  Fixed error with Crosstab for Smart Browser
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants