-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed error when a Purchase order is voided #3449
Fixed error when a Purchase order is voided #3449
Conversation
## Step by Step - Create a Purchase Order - Create a Receipt from Purchase Order - Void the PO ## What is wrong? When the PO is voided, the MM Receipt is completed and exist a deadlock The PR just add a validation for PO when is void for verify if exist a receipt. Note: when a PO is based on **Warehouse Order** the receipt are automatically reversed Please merge it with squash
hi @yamelsenih Yamel, The code seems OK. It makes sure that a Purchase Order cannot be voided if there has been already a material receipt. My problem is that I could not reproduce the error: Trial I
Trial II
Perhaps I am missing something? |
* develop: (63 commits) Fixed error with Dependent Entities for Record Access (adempiere#3480) Remove deprecated methods for Order (adempiere#3484) Fixed error when a Purchase order is voided (adempiere#3449) adempiere#3469 [Bug Report] In the process Generate an Invoice from the Receipt is not validate if an Invoice was generated adempiere#3469 (adempiere#3470) adempiere#3467 [Bug Report] Generate Receipt from Invoice process is not validate if was generate a Material Receipt from a previous execution adempiere#3467 (adempiere#3468) adempiere#3462 [Bug Report] Total matched invoice qty adempiere#3462 (adempiere#3464) Improve Standard Request Type (adempiere#3453) Revert "adempiere#3266 Error in calculating quantity ordered or reserved for Sales Order, manufacturing order and distribution order adempiere#3266" Update IT_Query to be more robust in the case where there are multiple clients in the database. The previous tests assumed the seed was being used for the test which may not always be correct. (+1 squashed commits) adempiere#3465 [Bug Report] Error when try delete a material receipt created from Invoice adempiere#3465 Add support to included role for ASP This pull request allows merge the ASP for a role when this is part of other role as include roles Fix parent link Fixed error with parent link for W_Category Add some columns for RV_C_RFQResponse Fixed wrong search for concept acct When a **Payroll Process** is processed and is create facts, the account from concept is created based on Account Schema, payroll of process and business partner group. Add Purchasing Tab to Business Partner Fixed error with Import ARXML of Print format When a print format is header and line like is **Invoice Header** and the print format is exported as .arxml format. The definition is exported but when is imported in other ADempiere instance the lines are missing. Fixed error with NPE for system reports When a print format is created from system and called from a company is throwed a error NPE: Update release.yml Update ExportReference.sh ... # Conflicts: # base/src/org/compiere/model/MOrder.java
* develop: (29 commits) Add overwrite values from Smart Browser field Allows define system events for validation of Standard Request Type Validate client Add better approach for validation engine Add optional value for source price list Add support to data type as mapping from entities (adempiere#3476) Adding the Weight and Volume field into Sales Order and Purchase Order Feature/3473 (adempiere#3474) Add the database function to get the daily salary (adempiere#3458) Error in calculating quantity ordered or reserved for manufacturing order and distribution order (adempiere#3472) Fixed error with missing parameter for Requisition PO Create (adempiere#3475) Fixed error with Dependent Entities for Record Access (adempiere#3480) Remove deprecated methods for Order (adempiere#3484) Fixed error when a Purchase order is voided (adempiere#3449) Update MPPForecastDefinitionLine.java adempiere#3469 [Bug Report] In the process Generate an Invoice from the Receipt is not validate if an Invoice was generated adempiere#3469 (adempiere#3470) adempiere#3467 [Bug Report] Generate Receipt from Invoice process is not validate if was generate a Material Receipt from a previous execution adempiere#3467 (adempiere#3468) adempiere#3462 [Bug Report] Total matched invoice qty adempiere#3462 (adempiere#3464) Fixed error with translation value for reference fix: BP Group getSQlWhere in Forecast Run Create. Fixed error with Crosstab for Smart Browser ...
Step by Step
What is wrong?
When the PO is voided, the MM Receipt is completed and exist a deadlock
The PR just add a validation for PO when is void for verify if exist a
receipt.
See the message:
![Screenshot_20210424_123024](https://user-images.githubusercontent.com/2333092/115966217-9f84ec80-a4fa-11eb-834b-fef2d03454af.png)
Note: when a PO is based on Warehouse Order the receipt are
automatically reversed
Please merge it with squash