Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3467 [Bug Report] Generate Receipt from Invoice process is not valid… #3468

Merged
merged 1 commit into from
Jun 26, 2021

Conversation

e-Evolution
Copy link
Contributor

…ate if was generate a Material Receipt from a previous execution #3467

…not validate if was generate a Material Receipt from a previous execution adempiere#3467
@e-Evolution e-Evolution added this to the 3.9.4 milestone May 23, 2021
@e-Evolution e-Evolution self-assigned this May 23, 2021
@marcalwestf marcalwestf added 09 Pending Peer Review 10 Reviewed by Peer 17 Waiting for Information Information needed to continue testing 19 Not reproducible The bug/error not reproducible as described and removed 09 Pending Peer Review labels Jun 4, 2021
@marcalwestf
Copy link
Collaborator

hi Victor @e-Evolution please see my comment on #3467
Thanks

@marcalwestf
Copy link
Collaborator

@e-Evolution now that the error has been reproduced, I will proceed to test the fix.

@marcalwestf marcalwestf added 09 Pending Peer Review 23 Reproduced The case could be reproduced 10 Reviewed by Peer and removed 10 Reviewed by Peer 19 Not reproducible The bug/error not reproducible as described 17 Waiting for Information Information needed to continue testing 09 Pending Peer Review labels Jun 5, 2021
@marcalwestf
Copy link
Collaborator

marcalwestf commented Jun 9, 2021

hi @e-Evolution, I did the following in Adempiere standard:

  1. Create a Purchase Order and complete it.
  2. Create an Invoice (Vendor) and generate the Invoice Line based on the Purchase Order. Complete the Invoice.
  3. Stay on the Invoice (Vendor) and Create a Material Receipt.
  4. Do not complete the material receipt.
  5. Create as many Material Receipts as you please and leave them in the Draft status.

This is an error because users can create a Material Receipt for an Invoice, and choose not to complete it.
Then, by mistake, another Material Receipt can be created out of the same Invoice. Now we'd have two Material receipts for the same invoice.
In the end, all drafted Material Receipts can be completed, leaving in a complete disarray the warehouse, and order.

With the changes of this pull request, you get the following message when there is a Material Receipt even in the Draft status:
imagen

Copy link
Collaborator

@marcalwestf marcalwestf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tested the behavior of standard Adempiere: it is possible to create several Material Receipts out of an Invoice (Vendor) if they are left in the Drafted status.
  • with this pull request, this (erroneous) behavior is suppressed.

-> test passed

@marcalwestf
Copy link
Collaborator

@e-Evolution Victor, some checks must pass

@marcalwestf
Copy link
Collaborator

This PR is semantically linked to #3462 and #3464

@yamelsenih
Copy link
Member

I agree, just update this branch with last changes for approval from CI

@yamelsenih yamelsenih merged commit c8e07e8 into adempiere:develop Jun 26, 2021
e-Evolution added a commit to e-Evolution/adempiere that referenced this pull request Jun 28, 2021
* develop: (63 commits)
  Fixed error with Dependent Entities for Record Access (adempiere#3480)
  Remove deprecated methods for Order (adempiere#3484)
  Fixed error when a Purchase order is voided (adempiere#3449)
  adempiere#3469 [Bug Report] In the process Generate an Invoice from the Receipt is not validate if an Invoice was generated adempiere#3469 (adempiere#3470)
  adempiere#3467 [Bug Report] Generate Receipt from Invoice process is not validate if was generate a Material Receipt from a previous execution adempiere#3467 (adempiere#3468)
  adempiere#3462 [Bug Report] Total matched invoice qty adempiere#3462 (adempiere#3464)
  Improve Standard Request Type (adempiere#3453)
  Revert "adempiere#3266 Error in calculating quantity ordered or reserved for Sales Order, manufacturing order and distribution order adempiere#3266"
  Update IT_Query to be more robust in the case where there are multiple clients in the database.  The previous tests assumed the seed was being used for the test which may not always be correct. (+1 squashed commits)
  adempiere#3465 [Bug Report] Error when try delete a material receipt created from Invoice adempiere#3465
  Add support to included role for ASP This pull request allows merge the ASP for a role when this is part of other role as include roles
  Fix parent link
  Fixed error with parent link for W_Category
  Add some columns for RV_C_RFQResponse
  Fixed wrong search for concept acct When a **Payroll Process** is processed and is create facts, the account from concept is created based on Account Schema, payroll of process and business partner group.
  Add Purchasing Tab to Business Partner
  Fixed error with Import ARXML of Print format When a print format is header and line like is **Invoice Header** and the print format is exported as .arxml format. The definition is exported but when is imported in other ADempiere instance the lines are missing.
  Fixed error with NPE for system reports When a print format is created from system and called from a company is throwed a error NPE:
  Update release.yml
  Update ExportReference.sh
  ...

# Conflicts:
#	base/src/org/compiere/model/MOrder.java
e-Evolution added a commit to e-Evolution/adempiere that referenced this pull request Jul 1, 2021
* develop: (29 commits)
  Add overwrite values from Smart Browser field
  Allows define system events for validation of Standard Request Type
  Validate client
  Add better approach for validation engine
  Add optional value for source price list
  Add support to data type as mapping from entities (adempiere#3476)
  Adding the Weight and Volume field into Sales Order and Purchase Order  Feature/3473 (adempiere#3474)
  Add the database function to get the daily salary (adempiere#3458)
  Error in calculating quantity ordered or reserved for manufacturing order and distribution order  (adempiere#3472)
  Fixed error with missing parameter for Requisition PO Create (adempiere#3475)
  Fixed error with Dependent Entities for Record Access (adempiere#3480)
  Remove deprecated methods for Order (adempiere#3484)
  Fixed error when a Purchase order is voided (adempiere#3449)
  Update MPPForecastDefinitionLine.java
  adempiere#3469 [Bug Report] In the process Generate an Invoice from the Receipt is not validate if an Invoice was generated adempiere#3469 (adempiere#3470)
  adempiere#3467 [Bug Report] Generate Receipt from Invoice process is not validate if was generate a Material Receipt from a previous execution adempiere#3467 (adempiere#3468)
  adempiere#3462 [Bug Report] Total matched invoice qty adempiere#3462 (adempiere#3464)
  Fixed error with translation value for reference
  fix: BP Group getSQlWhere in Forecast Run Create.
  Fixed error with Crosstab for Smart Browser
  ...
@e-Evolution e-Evolution deleted the feature/3467 branch July 12, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 bug 10 Reviewed by Peer 13 Pending Acceptance For Pull Requests: Pending Acceptance 23 Reproduced The case could be reproduced (AP) Account Payable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants