[Bug Report] Generate Receipt from Invoice process is not validate if was generate a Material Receipt from a previous execution

[e-Evolution]

Bug report

Generate Receipt from Invoice process is not validate if was generate a Material Receipt from a previous execution enable the possibility that generate multiple times causing inconsistencies.

Steps to reproduce

1.-Create an Invoice from Purchase Order And Complete the document
2.-Generate Receipt from Invoice and go Material Receipt and complete.
3.-Try Generate Receipt from Invoice and the process generate other receipt again

Screenshot or Gif

Expected behavior

The system only need allow generate a single Material Receipt by Invoice Line

Other relevant information

• Your OS: MacOS
• Java version: 1.8
• ADempiere version: 3.9.3
• Browser safari
• DB Provider: Pg
• DB version:12.2

[marcalwestf]

hi Victor @e-Evolution ,
just followed your steps to reproduce, but I couldn't create a Material Receipt twice:

1.- Working with Adempiere and a 393 database:

2- Create and Complete a Purchase Order

3. Create and complete an Invoice based on the Purchase Order:
   

4.- Generate and complete a Material Receipt based on the Purchase Invoice:

5.- Try to generate a Material Receipt from the same Purchase Invoice:

-> Adempiere doesn't allow to create a Material Receipt twice.

Perhaps I am using a different configuration or doing a different workflow?
Thanks

[e-Evolution]

@marcalwestf hola Mario, the problem is when create múltiples invoices for an single purchase order , so the case is when you hace the parcial receipt

because the matched is with first material receipt always

Kind regards

[marcalwestf]

aaah OK @e-Evolution Victor thanks for the explanation.

I thus did the following:
1.- Create and complete a Purchase Order for one product e.g. 666 units.
2.- Create a Purchase Invoice; generate the Invoice Line based on the Purchase Order (e.g. 111 units). Complete this partial Invoice.
3.- Stay at the Invoice; generate and complete a Material Receipt.
4.- Repeat step 2 with another quantity. You will notice that t the Invoice line has already a reference to the Receipt Line created in step 2 !!
5.- Repeat step 3.
6.- Repeat steps 2 and 3 until the quantity of the Purchase Order has been reached.
7.- Repeat step 3: It is possible to create Material Receipts from the Invoice even if the quantity of the Purchase Order has been reached.

-> Error reproduced.

[nsarlabos]

Hi @e-Evolution, we have tried and found an error, below are the steps we do:

• Create a purchase order and complete it
• Create an invoice (vendor) and its lines using the "Create From Order / Receipt" button, then complete it
• From the invoice, generate the receipt of materials using the "Generate Receipt from Invoice" button

What happens is that the material receipt is not generated, and the following error message is obtained:

Checking the "InvoiceCreateInOut" class, this happens in the "createLine (MInvoice invoice, MInvoiceLine invoiceline)" method.
In our test, where the ordered quantity was 100 and also the invoiced quantity, the value obtained for the variable "qtyNotMatched" is -100, so the method makes a "return" and the material receipt header remains null, returning the above error on line 80 of the class in mentioned.