Error in calculating quantity ordered or reserved for manufacturing order and distribution order #3472
Conversation
…Sales Order, manufacturing order and distribution order adempiere#3266 - Create new method to force same Warehouse for Sales Order Line but SO/PO - Create new calculate order sizes - Added new logic for that the Qty Reserved is only setting when the product is Stocked
…Sales Order, manufacturing order and distribution order adempiere#3266 - Fixed ideation code
…manufacturing order and distribution order adempiere#3266 - Remove unnecessary code - Improvement of the code separating the behavior of calculation of weight and volume of the reservation process. A good practice is that a function method in the code should be responsible for only one behavior
|
@e-Evolution hi Victor, this seems to be an important issue for Libero Manufacturing. Could you please write a step-by-step way to test it? Thanks! |
|
... and the build conflict solved... |
marcalwestf
added
the
17 Waiting for Information
@marcalwestf Hi Mario This change applies a best practice in code development, based on the SOLID responsibility principle, a method should only have one purpose or responsibility, so the reservation method not should also calculate the total weight and volume. So this pull request separates the logic of calculating weight and volume from the reservation method to an independent method and calls the method after the quantities were reserved, it also removes commented code that should not be more. To validate the tests you must follow the following steps: 1.- Find a product and add weight and volume |
|
Hi @e-Evolution @marcalwestf I approve this, the old PR was very wrong but @e-Evolution change this following my comments. Best regards |
|
@e-Evolution Victor, could you please solve the conflicts in order to be able to accept the PR? |
marcalwestf
added
10 Reviewed by Peer
14 Waiting for User Changes
There was a problem hiding this comment.
- Create a product with Weight and Volume
- Do an Inventory or a Material Receipt on this product
- Complete a Sales Order with this product
- Check the Volume and the Weight in the Sales Order Header
- Do the same with orders having several products with Weight and Volume defined
The Volume and the Weight in the Sales Order Header are according to the Weight/Volume defined and the quantities of the Order Lines. The same applies to reserved quantities.
-> Test passed.
marcalwestf
removed
the
14 Waiting for User Changes
* develop: (29 commits) Add overwrite values from Smart Browser field Allows define system events for validation of Standard Request Type Validate client Add better approach for validation engine Add optional value for source price list Add support to data type as mapping from entities (adempiere#3476) Adding the Weight and Volume field into Sales Order and Purchase Order Feature/3473 (adempiere#3474) Add the database function to get the daily salary (adempiere#3458) Error in calculating quantity ordered or reserved for manufacturing order and distribution order (adempiere#3472) Fixed error with missing parameter for Requisition PO Create (adempiere#3475) Fixed error with Dependent Entities for Record Access (adempiere#3480) Remove deprecated methods for Order (adempiere#3484) Fixed error when a Purchase order is voided (adempiere#3449) Update MPPForecastDefinitionLine.java adempiere#3469 [Bug Report] In the process Generate an Invoice from the Receipt is not validate if an Invoice was generated adempiere#3469 (adempiere#3470) adempiere#3467 [Bug Report] Generate Receipt from Invoice process is not validate if was generate a Material Receipt from a previous execution adempiere#3467 (adempiere#3468) adempiere#3462 [Bug Report] Total matched invoice qty adempiere#3462 (adempiere#3464) Fixed error with translation value for reference fix: BP Group getSQlWhere in Forecast Run Create. Fixed error with Crosstab for Smart Browser ...
Related with #3266
A good practice is that a function method in the code should be responsible for only one behavior
replace #3452