Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding return stdout (if number) and exit status #1

Closed
yosefy opened this issue Nov 21, 2016 · 4 comments
Closed

adding return stdout (if number) and exit status #1

yosefy opened this issue Nov 21, 2016 · 4 comments

Comments

@yosefy
Copy link

yosefy commented Nov 21, 2016

hi is it possible to do?
it would save lots of time for us
thanks

@jkassemi
Copy link
Contributor

Reporting on stdout may be beyond scope. Would specifying an option to check for content within the stdout or for an expected return code help satisfy the requirements?

@yosefy
Copy link
Author

yosefy commented Nov 21, 2016

why so?
most of the scripts we run we get something , like last example i was asked
to monitor:
need a result of:
############
mysql -e "show full processlist" | grep -c -v Sleep
############
so if i could get the result of your exporter i am done there

other wise:
i run it from script_exporter and push to pushgateway from another script
or put in node_exporter file...
and then get consistent with everything with labels

i would be very happy with first option.

why d u you think its beyond scope?

thanks

On Mon, Nov 21, 2016 at 5:24 PM, James Kassemi notifications@github.com
wrote:

Reporting on stdout may be beyond scope. Would specifying an option to
check for content within the stdout or for an expected return code help
satisfy the requirements?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMVy7Zgc3bqfjRLaDTDqLwM1bvfL9jXbks5rAbengaJpZM4K4DZq
.

@jkassemi
Copy link
Contributor

I can see the desired utility of the feature - my concern would be over defining the coercion of the result and ensuring it's only attempted on success. An additional gauge would be required for each configured script to avoid mixing types, as it doesn't make sense to combine successful result counts and mysql process counts, for instance.

This does go beyond my initial scope - if you're interested in adding the functionality I'd definitely take a look at a PR, but merge would really depend on tight the configuration for this would feel.

@yosefy
Copy link
Author

yosefy commented Nov 23, 2016

amm not really
i usually need the number form stdout
nevermind then

thanks

On 21 Nov 2016, at 23:14, James Kassemi notifications@github.com wrote:

I can see the desired utility of the feature - my concern would be over defining the coercion of the result and ensuring it's only attempted on success. An additional gauge would be required for each configured script to avoid mixing types, as it doesn't make sense to combine successful result counts and mysql process counts, for instance.

This does go beyond my initial scope - if you're interested in adding the functionality I'd definitely take a look at a PR, but merge would really depend on tight the configuration for this would feel.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #1 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AMVy7Vzjt2z2hbPQq5gacrf4smC-yxfCks5rAgmygaJpZM4K4DZq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants