Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update DQ_EvaluationMethodTypeCode codelist description #56

Closed
2 tasks done
hmaier-fws opened this issue Feb 1, 2024 · 5 comments · Fixed by #53
Closed
2 tasks done

Review and update DQ_EvaluationMethodTypeCode codelist description #56

hmaier-fws opened this issue Feb 1, 2024 · 5 comments · Fixed by #53
Assignees

Comments

@hmaier-fws
Copy link
Contributor

hmaier-fws commented Feb 1, 2024

The following items are needed to fully close out #37

  • Identify perferrred list description
  • Replace instances of "data set" with "dataset" (as per comment below, use "data set" spelling as in the standards document)

List description

The iso_evaluationMethodTypeCode.yml code list uses the description "type of method for evaluating an identified data quality measure", which seems to be based on https://standards.iso.org/iso/19157/resources/Codelists/gml/DQ_EvaluationMethodTypeCode.xml.

However, https://standards.iso.org/iso/19157/-2/mdq/1.0/codelists.xml and https://standards.iso.org/iso/19157/resources/Codelists/cat/codelists.xml both describe the list as "description of the evaluation method and procedure applied".

Which is the authoritative source for the DQ_EvaluationMethodTypeCode codelist?

Correct spelling of "data set"

The list item descriptions use the spelling "data set", this differs from ISO, which uses "dataset'.

@hmaier-fws
Copy link
Contributor Author

@dwalt which of the above is the authoritative source for theDQ_EvaluationMethodTypeCode?

@dwalt
Copy link

dwalt commented Feb 1, 2024

@dwalt @jwaspin The ISO doc uses "data set". We should follow that spelling.

@hmaier-fws
Copy link
Contributor Author

@dwalt OK, we'll retain the "data set" spelling. Which definition does the document use?

(Seems that the ISO Data Quality group has some data quality problems, you'd think they would want the code lists to match the documentation)

@dwalt
Copy link

dwalt commented Feb 2, 2024

@hmaier-fws I have looked at at 19157:2013, :2018 and :2023, the definition is consistent as: "Type of method used to evaluate quality of the data." I do not know why the XML definition varies.

Looking at the 19157:2023 version, which is a full replacement of prior versions, codelist definitions now use "dataset"! It also drops the use of DQ_ prefixes and renames classes in place: QualityElement instead of DQ_Element. QualityResult instead of DQ_Result, Completeness instead of DQ_Completeness.

@hmaier-fws
Copy link
Contributor Author

hmaier-fws commented May 24, 2024

closed by #53

@hmaier-fws hmaier-fws linked a pull request May 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants