Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resourceTimePeriod #23

Closed
jlblcc opened this issue Oct 29, 2014 · 15 comments
Closed

Add resourceTimePeriod #23

jlblcc opened this issue Oct 29, 2014 · 15 comments

Comments

@jlblcc
Copy link
Member

jlblcc commented Oct 29, 2014

                      "resourceTimePeriod": {
                          "description":"Period of resource",
                          "beginPosition":"1977-12-14",
                          "endPosition":"2007-08-13"
                        }
@stansmith907
Copy link
Contributor

I suggest we

  • add the resourceTimePeriod under citation
  • use the format for an ISO TimePeriod
  • and change beginPosition and endPosition to startDate and endDate
  • although all dateTime formats would be permitted.
  • implementation in ISO will show the start and end dates in a separate EX_Extent with a single temporalElement.
        "resourceInfo": {
            "citation": { },
            "resourceTimePeriod": {
                "description": "",
                "startDate": "0000-00-00",
                "endDate": "0000-00-00"
            }
        }

@dwalt
Copy link
Collaborator

dwalt commented Oct 29, 2014

While I like the proposal, would this entail creating a second extent if
there is a geospatial component, or would we add that to the same extent?
This issue being clearinghouse acceptance of multiple extents.

On Wed, Oct 29, 2014 at 10:41 AM, stansmith907 notifications@github.com
wrote:

I suggest we

  • add the resourceTimePeriod under citation

  • use the format for an ISO TimePeriod

  • and change beginPosition and endPosition to startDate and endDate

  • although all dateTime formats would be permitted.

  • implementation in ISO will show the start and end dates in a
    separate EX_Extent with a single temporalElement.

    "resourceInfo": {
        "citation": { },
        "resourceTimePeriod": {
            "description": "",
            "startDate": "0000-00-00",
            "endDate": "0000-00-00"
        }
    }
    


Reply to this email directly or view it on GitHub
#23 (comment)
.

@jlblcc
Copy link
Member Author

jlblcc commented Oct 29, 2014

When you say:

add the resourceTimePeriod under citation

You're not suggesting to add this to the citation object?

I would prefer to use the same schema for time period, i.e. leave beginPosition and endPosition. That makes more sense schema-wise.

@stansmith907
Copy link
Contributor

under extent

I was just referring to the position of the object in the adiwgJson, it would not be part of the citation object.

would this entail creating a second extent?

I think we should place the temporalElement in its own extent - not attached to any geographic object, which could have its own temporal extent describing the geometry.

I would prefer to use the same schema for time period

It doesn't cause me any problems in the reader to use different names than we use in temporal element. And since this is mostly a descriptor for projects I thought using more "project friendly" names would be nice. Is this an issue for the schema? The object name is already different - "resourceTimePeriod" - but that is likely a different matter.

@jlblcc
Copy link
Member Author

jlblcc commented Oct 29, 2014

I'd have to write another schema object since the property names are different.

@stansmith907
Copy link
Contributor

Then let's stick with beginPeriod and endPeriod. There not terrible.

@stansmith907
Copy link
Contributor

We need some rules ...

  • resourceTimePeriod - optional (recommended for projects)
  • description - optional
  • beginPeriod, endPeriod - at least one of these are required

jlblcc added a commit that referenced this issue Oct 29, 2014
@jlblcc
Copy link
Member Author

jlblcc commented Oct 29, 2014

Added to schema, see: http://www.adiwg.org/mdJson-schema-viewer

@stansmith907
Copy link
Contributor

I know that earlier I said resourceTimePeriod should not be an array. I'm having second thoughts. Should we allow multiple time periods to allow expression of non-contiguous activity?

@jlblcc
Copy link
Member Author

jlblcc commented Oct 29, 2014

I say folks can use an extent for that. I think we should define the resourceTimePeriod as the period covering the entire span, regardless of breaks, for which there was/is/expected to be resource activity, i.e. start/end date. Otherwise, why not just drop resourceTimePeriod and use extent?

@stansmith907
Copy link
Contributor

Works for me. Just double checking while I'm in the program.

@dwalt
Copy link
Collaborator

dwalt commented Oct 30, 2014

Ran across this from data.gov, project open data. Scroll down to spatial
and temporal sections.

http://project-open-data.github.io/schema/

On Wed, Oct 29, 2014 at 3:23 PM, stansmith907 notifications@github.com
wrote:

Works for me. Just double checking while I'm in the program.


Reply to this email directly or view it on GitHub
#23 (comment)
.

@stansmith907
Copy link
Contributor

Pushed mdTranslator 0.8.7 w/ support for resource time period.

Josh - before you publish the translator gem you might want to edit the gemspec to set a matching ADIwg-json-schema version. Also, I noticed the json-schema gem version jumped from 2.2 to 2.4.1 yesterday. Any chance it covers our windows problem?

@stansmith907
Copy link
Contributor

That's a horrible JSON structure! (I felt like I needed to tweet that)

@jlblcc
Copy link
Member Author

jlblcc commented Oct 30, 2014

My pull request, voxpupuli/json-schema/pull/109, is still sitting there, but there's been some comments on it in the last few days. Maybe it'll be resolved soon.

I need to build another adiwg-json-schemas gem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants