Added replaceKeys method #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I think @sebv should merge and publish a new version of WD. When that's done we can bump the version in Appium and commit the tests for the server-side method. |
This was referenced Aug 15, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added replace and replaceKeys functions for the "replace" parameter that I'm going to add in setText.java.
Was going to do this all in element-commands.js, but it looks like I would need to add 12 dependencies and an init function, so I thought it may be cleaner to keep it in two files. If that isn't as neat I can just move them.
This has been tested in conjunction with the "replace" param and works without any errors.