-
Notifications
You must be signed in to change notification settings - Fork 0
Dev Flow
To develop you need to follow this steps:
-
Go to master and pull
git checkout master
git pull
-
Create a local branch using the ticket keywords and Pivotal id like this:
git checkout -b "<ticket_keywords>-<pivotal_id>"
git checkout -b "mixpanel-hooks-87511218"
-
Code and commits
some very clean code
git commit -a -m "[#<pivotal_id>] <solution_description>"
git commit -a -m "[#87511218] Created a new service that gets the data from webhooks and sends it to mixpanel"
-
When you are done, pull from master, and rebase with the appropriate naming while squashing all your commits into one
git checkout master
git pull master
git checkout <ticket_keywords>-<pivotal_id>
git rebase -i master
-
If you have conflict, resolve, add files
git rebase --continue
-
Either way, push to branch
git push -f origin "<ticket_keywords>-<pivotal_id>"
git push origin "mixpanel-hooks-87511218"
-
Wait for the deploy, then go to the url of your branch and TEST IT VERY WELL (you are responsable)
http://<branch_name>-<repo_name>.<our_paas>
-
If it works, go to Github.com and create Pull Request to Master branch with a name that has the pivotal_id and the ticket keywords
[#<pivotal_id>] <ticket_keywords>
"[#87511218] Implemented the Mixpanel Hook"
-
In the description, describe the issue and your solution, comment any important lines
You can use these titles: Issue, Story, Cause, Solution
Issue: (for bugs)
Story: Need to import user actions to mixpanel
Cause: (for bugs)
Solution: Created a new service that gets the data from webhooks and sends it to mixpanel
-
Ask for someone to review your code by mentioning him in the Pull Request
-
If he accepts it: Merge to Master, wait for the deploy, TEST IN PRODUCTION
It is your responsibility to break things in production!
-
If all is good: Delete branch
-
In Pivotal mark as delivered, explain how someone can test to accept or reject.