Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE9 - shift + tab at top level nav-item causes exception... #6

Closed
javagenie opened this issue Jan 17, 2014 · 2 comments
Closed

IE9 - shift + tab at top level nav-item causes exception... #6

javagenie opened this issue Jan 17, 2014 · 2 comments

Comments

@javagenie
Copy link

To reproduce the error: tab to menu, expand a sub-nav level menu, (shift+tab) and you will see the javascript error. I found that it happens anytime you try to shift+tab out of a sub-nav menu and reach the top level nav-item element.

I was able to work-around it by adding a try{}catch{} to the var target declaration and exit the offending code. Sorry, I didn't dig deeper to find the cause and a more elegant solution. Let me know if I can help in any way. My evaluation of this plugin has been terrific up until this issue. Well done! If I could offer an enhancement suggestion... that would be to turn off the alpha-numeric navigation somehow. It's generally a great feature, but I had an instance where we wanted a menu to have a user input field and the alpha nav broke this capability (so I had to comment out the keyMap items which turned it off across the board). :( Anyway... great job! Thanks!!!!

Errors generated by IE that I noted while testing on your example site and in my dev environment:
Message: Unable to get property 'settings' of undefined or null reference
Line: 219
Char: 17
Code: 0
URI: http://adobe-accessibility.github.io/Accessible-Mega-Menu/js/jquery-accessibleMegaMenu.js

Message: Unable to get property 'topNavItemClass' of undefined or null reference
Line: 418
Char: 17
Code: 0
URI: http://localhost/tests/jquery-accessibleMegaMenu.js
majornista added a commit that referenced this issue Jan 17, 2014
@majornista
Fixes Issue #6
e618bc8 
Line 518: Fix keydown handler for TAB key calling _togglePanel with the
wrong scope.
Line 413: Corrects discovery of the plugin instance when the scope is a
hovered element rather than a focused element menu item.
Line 433: If the event.target is a form element rather than a menu
item, we should handle keydown normally,  just passing it through to
the control.
majornista added a commit that referenced this issue Jan 17, 2014
@majornista
Fixes Issue #6
eba3e8a 
Line 518: Fix keydown handler for TAB key calling _togglePanel with the
wrong scope.
Line 413: Corrects discovery of the plugin instance when the scope is a
hovered element rather than a focused element menu item.
Line 433: If the event.target is a form element rather than a menu
item, we should handle keydown normally,  just passing it through to
the control.
@majornista
Copy link
Member

Thanks for your recommendation, I've implemented fixes for both of your suggestions. Cheers!

@javagenie
Copy link
Author

Wow... that was fast and great solutions for both. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@majornista @javagenie