-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cli issues #13
base: main
Are you sure you want to change the base?
Fix cli issues #13
Conversation
@Govind-gupta75 does it fix also automated testing via webdriver.io on Windows? |
@@ -15,9 +15,6 @@ | |||
"postinstall": "node scripts/installScript.js", | |||
"cleanup": "node scripts/cleanup.js" | |||
}, | |||
"cpu": [ | |||
"!arm64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you may need to update the README here to reflect the change in arm support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemahony yes, I am working on fixing these.
Could we have this not hard-coded please? devtools-cli/packages/uxp-devtools-core/src/core/client/plugin/actions/PluginTestBaseCommand.js Line 101 in 7b9fd64
It forces me to have Maybe I would preffer to not have mandatory entry in my package.json. Also is it possible to get rid off "yarn" dependency in order to run tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
No description provided.