Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli issues #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Govind-gupta75
Copy link

No description provided.

@jardicc
Copy link
Collaborator

jardicc commented Jun 3, 2024

@Govind-gupta75 does it fix also automated testing via webdriver.io on Windows?

@@ -15,9 +15,6 @@
"postinstall": "node scripts/installScript.js",
"cleanup": "node scripts/cleanup.js"
},
"cpu": [
"!arm64"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you may need to update the README here to reflect the change in arm support?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikemahony yes, I am working on fixing these.

@jardicc
Copy link
Collaborator

jardicc commented Jul 26, 2024

Could we have this not hard-coded please?

const args = [ "uxp-plugin-tests", testParams.driverPort, testParams.udtServicePort, testParams.supportedHostApp, testParams.uxpPluginID ];

It forces me to have uxp-plugin-tests script in parent package.json related to test files.

Maybe I would preffer to not have mandatory entry in my package.json.

Also is it possible to get rid off "yarn" dependency in order to run tests?

Copy link

@Idalis2fashion Idalis2fashion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants