Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compiling with Visual Studio 2022 #9

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

olihey
Copy link
Contributor

@olihey olihey commented Mar 25, 2024

Adds support to compile the project with Visual Studio 2022

Description

Modified FindFBXSDK.cmake to find the correct FBX SDK lib folder for version 2020.3.0 and later

Related Issue

Motivation and Context

Our USD pipeline is compiled with Visual Studio 2022 on Windows and we wanted to test the file format plugins in that pipeline.
We also ran the pytest from this project and it only failed 2 SBSAR test because we didn't compile support for SBSAR

How Has This Been Tested?

It compiles with FBX SDK 2020.3.4 on Windows and we tested multiple FBX exports from USD files. No import tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kwblackstone
Copy link
Contributor

Looks great, thanks!

@kwblackstone kwblackstone merged commit 2ad1f81 into adobe:main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants