Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experience Fragment] Expand JSON content #943

Closed
gabrielwalt opened this issue Mar 9, 2020 · 1 comment · Fixed by #941
Closed

[Experience Fragment] Expand JSON content #943

gabrielwalt opened this issue Mar 9, 2020 · 1 comment · Fixed by #941
Labels
enhancement New feature, or improvement to an existing feature. pull request Has a pull request associated. requires new version Issue that requires a new component version as the fix would break compatibility.
Milestone
2.11.1

Comments

@gabrielwalt
Copy link
Member

The Experience Fragment component should export its referenced contents in the model JSON output, so that JS components can render its content without requiring an additional request to retrieve it.
@gabrielwalt gabrielwalt added enhancement New feature, or improvement to an existing feature. requires new version Issue that requires a new component version as the fix would break compatibility. pull request Has a pull request associated. labels Mar 9, 2020
@gabrielwalt gabrielwalt added this to the 2.9.0 milestone Mar 9, 2020
@niekraaijmakers niekraaijmakers mentioned this issue Mar 9, 2020
Merged
@joerghoh
Copy link
Collaborator

When implementing this please also consider the implications on caching and invalidation. The JSON might be cached on dispatcher and thus needs proper invalidation when the content of the XF changes.

@godanny86 godanny86 mentioned this issue Mar 11, 2020
Closed
@glasert glasert linked a pull request Apr 23, 2020 that will close this issue
[Experience Fragment] Expand JSON content #943 #941
Merged
@vladbailescu vladbailescu modified the milestones: 2.9.0, 3.0.0 May 8, 2020
vladbailescu pushed a commit that referenced this issue Jul 23, 2020
@niekraaijmakers
[Experience Fragment] Expand JSON content #943 (#941)
80f3f56 
* Experience Fragment also exports the actual contents of the experience fragment directly in itself
* Change fragment path to fragment variation path
* RAT files, test coverage
* Removed unused import
* improve test coverage to meet requirements
* formatting

Co-authored-by: Niek Raaijmakers <niek@adobe.com>
@vladbailescu vladbailescu mentioned this issue Jul 23, 2020
Merged
vladbailescu added a commit that referenced this issue Jul 24, 2020
@vladbailescu @niekraaijmakers
[Experience Fragment] Expand JSON content (#1117)
83d18a8 
* [Experience Fragment] Expand JSON content #943 (#941)

* Experience Fragment also exports the actual contents of the experience fragment directly in itself
* Change fragment path to fragment variation path
* RAT files, test coverage
* Removed unused import
* improve test coverage to meet requirements
* formatting
* Taking advantage of the new method to display placeholder for empty XFs.

Fixes #943

Co-authored-by: Niek Raaijmakers <niekraaijmakers@gmail.com>
Co-authored-by: Niek Raaijmakers <niek@adobe.com>
@vladbailescu vladbailescu modified the milestones: 3.0.0, 2.12.0 Jul 24, 2020
This was referenced Aug 14, 2020
Closed
Open
@vladbailescu vladbailescu modified the milestones: 2.12.0, 2.11.1 Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, or improvement to an existing feature. pull request Has a pull request associated. requires new version Issue that requires a new component version as the fix would break compatibility.
Projects
None yet
Milestone
2.11.1
Development

Successfully merging a pull request may close this issue.

[Experience Fragment] Expand JSON content #943 niekraaijmakers/aem-core-wcm-components
3 participants
@gabrielwalt @joerghoh @vladbailescu