Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITES-22027] Issue with Image Component Get caption from DAM field persistence #2757

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

YahorC
Copy link
Contributor

@YahorC YahorC commented May 23, 2024

disabling checkboxes in case image is deleted from drop section

Q                       A
Fixed Issues? https://jira.corp.adobe.com/browse/SITES-22027
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

@YahorC YahorC requested a review from a team May 23, 2024 17:14
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (a32c8a6) to head (18b4ec6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2757   +/-   ##
=========================================
  Coverage     87.17%   87.17%           
  Complexity     2683     2683           
=========================================
  Files           235      235           
  Lines          7166     7166           
  Branches       1094     1094           
=========================================
  Hits           6247     6247           
  Misses          363      363           
  Partials        556      556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Tag("IgnoreOnSDK")
@Test
@DisplayName("Test: clear asset input field, get Dam info checkboxes become invisible V3")
public void testClearAssetInputGetDamInfoCheckboxesNotVisible65() throws InterruptedException, TimeoutException {

Check notice

Code scanning / CodeQL

Missing Override annotation Note test

This method overrides
ImageIT.testClearAssetInputGetDamInfoCheckboxesNotVisible65
; it is advisable to add an Override annotation.
@Tag("IgnoreOn65")
@Test
@DisplayName("Test: clear asset input field, get Dam info checkboxes become invisible V3")
public void testClearAssetInputGetDamInfoCheckboxesNotVisibleSDK() throws InterruptedException, TimeoutException {

Check notice

Code scanning / CodeQL

Missing Override annotation Note test

This method overrides
ImageIT.testClearAssetInputGetDamInfoCheckboxesNotVisibleSDK
; it is advisable to add an Override annotation.
Copy link
Contributor

@LSantha LSantha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@LSantha LSantha merged commit 7582ad6 into main Jun 21, 2024
14 checks passed
@LSantha LSantha deleted the SITES-22027 branch June 21, 2024 07:10
@LSantha LSantha added this to the 2.26.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants