feat: update metadata fields from the challenger content #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shsteimer
commented
May 8, 2024
| @@ -14,6 +14,7 @@ const MAX_SAMPLING_RATE = 10; // At a maximum we sample 1 in 10 requests | |||
| export const DEFAULT_OPTIONS = { | |||
| // Generic properties | |||
| rumSamplingRate: MAX_SAMPLING_RATE, // 1 in 10 requests | |||
| overrideMetaFields: [], | |||
There was a problem hiding this comment.
I considered defaulting this to ['template', 'theme'] but reverted to empty to avoid this being a breaking change. If we aren't concerned about a breaking change, I think the list above is reasonably safe and should cover most cases where metadata affects rendering of the page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fix #23
Motivation and Context
How Has This Been Tested?
Tested with a customer on their live website where they were relying on the
templatemeta property for how things rendered.Screenshots (if appropriate):
Types of changes
Checklist: