Issue 84/sample content module #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgonzalez
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
the ui.content.sample naming feels more idiomatic with the Maven Archetype, naming where the . segments further describe the contents (similar to java packages).
TBH it might be worth asking the archetype team to update repository-structure project o be named ui.apps.structure.
godanny86
added a commit
that referenced
this pull request
Jul 13, 2020
* Issue 84/sample content module (#85) Co-authored-by: david g. <davidjgonzalez@users.noreply.github.com> * Shorten urls but also support image resolution in Site content (#87) * Shorten urls but also support image resoultion in Site content * Use CS runmodes to allow for local develoment. * Update sign-in-buttons.html Found a typo on line 37 - should be data-sly-test not data-sly.test * Issue 100 - Component Story Format migration (#102) * Core Components 2.10.0 and Archetype 23 (#105) * Enables data layer for core components * updated to remove hardcoded reference to /etc (#108) * Issue 109/component re org (#110) * re-organized components * component resource type re-organization * removed responsive grid and replaced with container from core components * Issue 111/improve performance (#112) * use an SVG over PNG * use smaller loading icon * include google fonts directly instead of the link * remove animate css since very little was being used * pre-load icon path since it will be called by the css * updated html * minor corrections to font inclusion * updated image size * fixes for sidebar container * Issue 113/distribute artifacts (#114) * updated pom and added info about releasing * moved release markdown file * updated license to MIT to be less restrictive (#116) Co-authored-by: david g. <davidjgonzalez@users.noreply.github.com> Co-authored-by: Bryan Stopp <bstopp@users.noreply.github.com> Co-authored-by: Kevin Roberts <kevin.roberts10@gmail.com> Co-authored-by: Subash Selvaraj <sselvara@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #84 - moving sample content to a samplecontent module.