Remove Edge Bridge Functional Test Utils to use TestUtils Classes #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Edge Bridge Functional Test Utils to use TestUtils
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #83 +/- ##
=============================================
+ Coverage 71.01% 96.00% +24.99%
- Complexity 0 48 +48
=============================================
Files 5 4 -1
Lines 138 150 +12
Branches 9 29 +20
=============================================
+ Hits 98 144 +46
+ Misses 32 6 -26
+ Partials 8 0 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
timkimadobe
reviewed
Jun 18, 2024
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Outdated
Show resolved
Hide resolved
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Outdated
Show resolved
Hide resolved
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Outdated
Show resolved
Hide resolved
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Outdated
Show resolved
Hide resolved
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Outdated
Show resolved
Hide resolved
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Show resolved
Hide resolved
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Outdated
Show resolved
Hide resolved
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Show resolved
Hide resolved
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Show resolved
Hide resolved
...e/src/androidTest/java/com/adobe/marketing/mobile/edge/bridge/EdgeBridgeFunctionalTests.java
Outdated
Show resolved
Hide resolved
Incorporate review comments
|
@timkimadobe thanks for the review, the PR is updated. |
timkimadobe
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Thank you for all the updates @cacheung! Just one small item
| " }" + | ||
| " ]" + | ||
| "}"; | ||
|
|
||
| assertEquals(1, networkRequests.size()); |
There was a problem hiding this comment.
Could we move this line to be above the declaration for expected, so its right after the getNetworkRequestsWith line?
Move the order of code
timkimadobe
approved these changes
Jun 19, 2024
addb
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Edge Bridge Functional Test Utils to use TestUtils TestHelper and MockNetworkServices.
Remove flatten Map usages in the functional tests.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: