Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support iam #21

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Support iam #21

merged 6 commits into from
Oct 12, 2023

Conversation

shandilya3
Copy link
Contributor

@shandilya3 shandilya3 commented Oct 10, 2023 •
edited
Loading

Description

"sticking with the existing implementation with the expectation with some changes to expect there will always be iam.id and iam.eventType in historical rulesets for IAM on the web"

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shandilya3 shandilya3 mentioned this pull request Oct 11, 2023
Merged
12 tasks
jasonwaters
jasonwaters reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@jasonwaters jasonwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple comments

src/historical.ts Outdated Show resolved Hide resolved
src/historical.ts Outdated Show resolved Hide resolved
src/historical.ts Outdated Show resolved Hide resolved
src/historical.ts Outdated Show resolved Hide resolved
@shandilya3 shandilya3 merged commit c04fef1 into adobe:main Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwaters jasonwaters jasonwaters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shandilya3 @jasonwaters