Target "prefetchContent" API #11

yangyansong-adbe · 2020-11-19T16:34:56Z

No description provided.

cdhoffmann

Still reviewing but some stuff to get started

AEPTarget/Sources/DeliveryRequest.swift

AEPTarget/Sources/DeliveryResponse.swift

AEPTarget/Sources/Target+PublicAPI.swift

AEPTarget/Sources/Target.swift

cdhoffmann

Changes look good 👍 LMK when tests are done so I can take a look again.

AEPTarget/Sources/TargetProduct+Internal.swift

AEPTarget/Sources/TargetParameters.swift

AEPTarget/Sources/TargetParameters+Internal.swift

AEPTarget/Sources/TargetConstants.swift

AEPTarget/Sources/DeliveryRequest.swift

AEPTarget/Sources/Target.swift

swarna04 · 2021-01-22T17:48:05Z

Provided feedback here @yangyansong-adbe, expect a few more comments. Please also provide test cases and documentation.

AEPTarget/Sources/TargetConstants.swift

AEPTarget/Sources/Target.swift

AEPTarget/Sources/TargetOrder.swift

ravjain-adb · 2021-02-10T18:52:59Z

AEPTarget/Sources/Target.swift

        super.init()
    }

    public func onRegistered() {
-        registerListener(type: EventType.target, source: EventSource.requestContent, listener: handle)
+        registerListener(type: EventType.target, source: EventSource.requestContent) { event in
+            if event.isPrefetchEvent {


Should we do this in the a new requestContentHandler method/callback. Otherwise this callback will become big

we can do it when handling other target request events.

AEPTarget/Sources/TargetError.swift

AEPTarget/Sources/DeliveryRequest.swift

AEPTarget/Sources/TargetConstants.swift

AEPTarget/Sources/TargetState.swift

AEPTarget/Sources/Target.swift

swarna04 · 2021-02-16T20:00:42Z

AEPTarget/Sources/Target.swift

@@ -16,7 +16,15 @@ import Foundation

 @objc(AEPMobileTarget)
 public class Target: NSObject, Extension {
-    internal static let LOG_TAG = "Target"
+    static let LOG_TAG = "Target"


Not resolved!

swarna04 · 2021-02-16T20:10:18Z

AEPTarget/Sources/TargetError.swift

+
+import Foundation
+
+class TargetError: Error, CustomStringConvertible {


Misread this one! Ignore my comment here.

AEPTarget/Sources/DeliveryRequest.swift

swarna04 · 2021-02-18T16:39:40Z

AEPTarget/Sources/DeliveryRequest.swift

+
+    private static func generateTargetContext() -> TargetContext? {
+        let deviceType: DeviceType = systemInfoService.getDeviceType() == AEPServices.DeviceType.PHONE ? .phone : .tablet
+        let mobilePlatform = MobilePlatform(deviceName: systemInfoService.getDeviceName(), deviceType: deviceType, platformType: .ios)


Use systemInfoService.getCanonicalPlatformName() for platformType. Let's not hardcode here since we do not want to manage this in Target code for the supported platforms.

Enum:"android" "ios" Only activities with the specified mobile platform type will be evaluated.

I think we don't need to do it as Target server side only supports above 2 types, and we will never send android type in Swift extension.

Yes, that's what I've been trying to point out that we should avoid trying to hardcode the value on each platform when we can read the value from systemInfoService like we were doing before TargetRequestBuilder.cpp#L506

AEPTarget/Sources/DeliveryRequest.swift

* Project skeleton (#8) * cleanup project (#9) cleanup project * Swift Class placeholder (#10) * Placeholder for Swift classes * review feedback * disable Github action for now * Circleci project setup (#23) * Add .circleci/config.yml * set up CircleCI * no message * no message * no message * Target "prefetchContent" API (#11) * wip: skeleton setup for prefetch API * more prefetch API details * clean up code * rearrange code * AEPError -> Error * fix test fails * review feedback * fix review comments * add more docs * format * update CI scripts * disable Github Action * review feedback * review feedback * wip: skeleton setup for prefetch API * more prefetch API details * clean up code * fix test fails * review feedback * fix review comments * add more docs * update CI scripts * disable Github Action * review feedback * display notification tracking api * Updating with Notification clicked api. * Rebasing from prefetch branch * Removing AEPIdentity from podspec * Fixing compile time errors * Changes based on comments * fixes based on review comments * Adding public api tests for displayed and clicked location * Create swift.yml * Preview manager test progress. Need to update once uiutil protocol is set up. * Add comment for preview manager protocol * Fix spacing * Swift format * Add comments for ui delegate extensions * Set up changes with UIService, mockable ui elements. * Fix typos and change log tag * Make sure preview token is not empty * update createFullscreenMessage api calls from dev. * add onshowfailure to fullscreenmessage delegate extension * Remove invalid string from log. * Removing unnecessary github actions * Reset Experience API * Updating the pr based on review comments * remove the usage of CustomIdentity (#41) * remove usage of CustomIdentity * add function docs * cleanup code * fix review comments * remove AEPIdentity dependency for AEPTarget target * use the latest valid configuration (#46) * Adding configuration response handling * Updating the tests * Fixes based on comments for tests * Batch API feature * Adding pair id for getting the response back to customer * Adding A4T functionality * Adding few unit tests * - Update api to handle response content event - Updating unit tests * Updating based on previous pr comments * Updating based on comments * Using thread safe dictionary * Fixing the tests * Adding Objective c app * ObjC App UI * attempt to fix UI mishap * objc app and changes in sdk for it * Updates based on comments * Adding clear prefetch cache implementation * Removing signal * add release scripts * add integration test - prefetch (#49) * add integration test - prefetch * clean up * Adding Assurance to target demo apps * release automation (#56) * Data migration (#52) * migration stored V5 data to new format * no message * fix review comments * Preview manager test progress. Need to update once uiutil protocol is set up. * Setup preview manager target class usage. * wip: skeleton setup for prefetch API * more prefetch API details * clean up code * fix test fails * review feedback * fix review comments * add more docs * Mock previewmanager and initial test for Target preview events * Updated * Removed extra files * Updating tests * Updating tests * Updating preview api * Updating demo app to send a generic os event * Rebasing after conflicts * Updating tests * add tests for prefetch (#61) * add tests * add tests and fix format * Seperating functioonal tests with unit tests * clean up project (#67) * retrieve configuration and update target state (#54) * retrieve configuration and update target state (option 1) * lint * store configuration shared state in TargetState object * fix tests fail * fix lint * add tests for TargetState * remove duplicated function * improve the readability of code (#73) * Add functional test and updates on the request processing (#74) * Adding more functional tests * Adding more tests * Add more integration tests (#69) * more tests * enable "testRetrieveLocationContent" * not use empty target server url (#75) * Adding more tests * using env id from configuration (#76) * Checking objc annotation for all the public apis * Refactor the code to update session timestamp in one place (#77) * refactoring * increase the timeout * adding missed objc annotation * V4 data migration (#63) * migration stored V5 data to new format * no message * data migration for V4 * manually merges the missing code * revert changes * no message * fix review comments * add some trace logs * increase timeout in tests * clean up Prefetch code and add more tests (#79) * not allow dispatching multiple error response events for prefetch API * add missing key ("prefetchresult") in prefetch response event * Update AEPTarget.podspec * Update Makefile * Updating the test app to use analytics * clean up tests code (#83) * Speed up CI times (#84) * no message * no message * no message * no message * no message * no message * no message * no message * add functional tests for loadRequest (#85) * Extension class should not call MobileCore.dispatch (#86) * Add docs for public APIs (#62) * add docs for prefetch API * revert changes for the demo apps * add syntax * Update AEPTarget.md * Update AEPTarget.md * add docs for public APIs * revert changes for demo apps * update readme * no message * no message * Update LICENSE * Update COPYRIGHT * add API description for "Viaual preview" * Migrates all functional test cases from ACPTarget project (prefetch/retrieve) (#87) * add functional tests for loadRequest * no message * no message * add tests for prefetch API * import SwiftJSON library to the test code * Migrates all functional test cases from ACPTarget project (session/edgeHost/reset ...) (#88) * add functional tests for loadRequest * no message * no message * add tests for prefetch API * import SwiftJSON library to the test code * more tests * no message * allow set nil for public API - setThirdPartyId (#89) * add tests for "LocationClicked" API (#90) * add tests for "LocationDisplayed" API (#91) * add more tests (#92) * GA release (#81) * update podspec for GA release * clean up project * revert format * fix format * update public API signature (#93) * update public API signature * update API comments * review comments * update test app * update all public APIs * doc * update tests * clean up API docs * Update codecov.yml Co-authored-by: Christopher Hoffmann <cdhoffmann@users.noreply.github.com> Co-authored-by: ravinsingh jain <ravjain@adobe.com> Co-authored-by: ravjain-adb <61328814+ravjain-adb@users.noreply.github.com> Co-authored-by: Christopher Hoffmann <choffman@adobe.com> Co-authored-by: pravin <pravinpk0707@gmail.com>

wip: skeleton setup for prefetch API

9d206b2

yangyansong-adbe added the DO NOT MERGE label Nov 19, 2020

yangyansong-adbe changed the title ~~WIP: skeleton setup for prefetch API~~ WIP: setup skeleton code for prefetch API Nov 19, 2020

yangyansong-adbe added 3 commits November 30, 2020 20:54

more prefetch API details

7514c3a

clean up code

1576db5

rearrange code

70bc57e

yangyansong-adbe changed the title ~~WIP: setup skeleton code for prefetch API~~ WIP: Target "prefetchContent" API Dec 2, 2020

yangyansong-adbe added 2 commits December 1, 2020 23:45

AEPError -> Error

030e5fe

fix test fails

9e961da

cdhoffmann requested changes Dec 3, 2020

View reviewed changes

review feedback

1127916

cdhoffmann approved these changes Dec 4, 2020

View reviewed changes

swarna04 requested changes Jan 22, 2021

View reviewed changes

fix review comments

383a98e

yangyansong-adbe removed the DO NOT MERGE label Feb 8, 2021

yangyansong-adbe changed the title ~~WIP: Target "prefetchContent" API~~ Target "prefetchContent" API Feb 8, 2021

yangyansong-adbe linked an issue Feb 8, 2021 that may be closed by this pull request

[Prefetch] API implementation #13

Closed

yangyansong-adbe added 3 commits February 8, 2021 14:18

add more docs

8ffef23

format

46aeff2

update CI scripts

8da91f8

cdhoffmann reviewed Feb 8, 2021

View reviewed changes

AEPTarget/Sources/TargetConstants.swift Outdated Show resolved Hide resolved

cdhoffmann requested changes Feb 9, 2021

View reviewed changes

AEPTarget/Sources/Target.swift Outdated Show resolved Hide resolved

ravjain-adb reviewed Feb 9, 2021

View reviewed changes

AEPTarget/Sources/TargetOrder.swift Show resolved Hide resolved

yangyansong-adbe added 2 commits February 9, 2021 21:08

add tests

66b779d

disable Github Action

6f95f92

ravjain-adb reviewed Feb 10, 2021

View reviewed changes

cdhoffmann reviewed Feb 11, 2021

View reviewed changes

AEPTarget/Sources/TargetError.swift Outdated Show resolved Hide resolved

swarna04 requested changes Feb 16, 2021

View reviewed changes

yangyansong-adbe mentioned this pull request Feb 17, 2021

[Prefetch] use the last valid config #33

Closed

yangyansong-adbe mentioned this pull request Feb 17, 2021

[Prefetch] attach the property token to the prefetch request #34

Closed

review feedback

0448330

swarna04 requested changes Feb 18, 2021

View reviewed changes

This was referenced Feb 18, 2021

[prefetch] missing the mapping for lifecycle data #37

Closed

[prefetch] remove hard dependency to AEPIdentity #38

Closed

review feedback

9999859

yangyansong-adbe merged commit 1fe717b into dev Feb 19, 2021

This was referenced Feb 19, 2021

[Discussion] several review comments for Prefetch code #39

Closed

remove the usage of CustomIdentity #41

Merged

yangyansong-adbe deleted the Prefetch branch April 9, 2021 19:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Target "prefetchContent" API #11

Target "prefetchContent" API #11

yangyansong-adbe commented Nov 19, 2020

cdhoffmann left a comment

cdhoffmann left a comment

swarna04 commented Jan 22, 2021

ravjain-adb Feb 10, 2021

yangyansong-adbe Feb 17, 2021

swarna04 Feb 16, 2021

swarna04 Feb 16, 2021

swarna04 Feb 18, 2021

yangyansong-adbe Feb 18, 2021

swarna04 Feb 19, 2021


		import Foundation

		class TargetError: Error, CustomStringConvertible {

Target "prefetchContent" API #11

Target "prefetchContent" API #11

Conversation

yangyansong-adbe commented Nov 19, 2020

cdhoffmann left a comment

Choose a reason for hiding this comment

cdhoffmann left a comment

Choose a reason for hiding this comment

swarna04 commented Jan 22, 2021

ravjain-adb Feb 10, 2021

Choose a reason for hiding this comment

yangyansong-adbe Feb 17, 2021

Choose a reason for hiding this comment

swarna04 Feb 16, 2021

Choose a reason for hiding this comment

swarna04 Feb 16, 2021

Choose a reason for hiding this comment

swarna04 Feb 18, 2021

Choose a reason for hiding this comment

yangyansong-adbe Feb 18, 2021

Choose a reason for hiding this comment

swarna04 Feb 19, 2021

Choose a reason for hiding this comment