Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aio app pack command #650

Merged
merged 44 commits into from
May 10, 2023
Merged

feat: aio app pack command #650

merged 44 commits into from
May 10, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented Apr 5, 2023

(this is based on the WIP PoC for the aio app package command)

How Has This Been Tested?

  • npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron mentioned this pull request Apr 5, 2023
10 tasks
@purplecabbage purplecabbage marked this pull request as ready for review April 18, 2023 02:34
@shazron shazron changed the title feat: aio app pack command feat: aio app pack command Apr 21, 2023
@shazron shazron self-assigned this Apr 21, 2023
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great mocks

Copy link
Member

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a couple nits.
We may need to move around the pre-pack/post-pack hook timing.
Also, should we skip cleaning up the output dir? While we are developing/integrating it might be good to have this easily inspectable. We do a similar thing with zipped actions where we do not discard the files so developers can easily see what is going in the zip.

src/commands/app/pack.js Outdated Show resolved Hide resolved
src/lib/app-helper.js Show resolved Hide resolved
@shazron
Copy link
Member Author

shazron commented May 8, 2023

Looks good, I left a couple nits. We may need to move around the pre-pack/post-pack hook timing.

@purplecabbage Is this a change we need in this PR? What changes are needed?

Also, should we skip cleaning up the output dir? While we are developing/integrating it might be good to have this easily inspectable. We do a similar thing with zipped actions where we do not discard the files so developers can easily see what is going in the zip.

We don't clean it up after the command is done - we only clean up at the start of the command

@shazron
Copy link
Member Author

shazron commented May 9, 2023

I'll merge this first thing tomorrow and do more testing, which will include #662

@shazron shazron merged commit 2134f1e into master May 10, 2023
@shazron shazron deleted the story/ACNA-2037 branch May 10, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants