-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aio app pack
command
#650
Conversation
…n and install.yaml creation
…sue, add ignored files
… fired for the Events plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, great mocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left a couple nits.
We may need to move around the pre-pack/post-pack hook timing.
Also, should we skip cleaning up the output dir? While we are developing/integrating it might be good to have this easily inspectable. We do a similar thing with zipped actions where we do not discard the files so developers can easily see what is going in the zip.
@purplecabbage Is this a change we need in this PR? What changes are needed?
We don't clean it up after the command is done - we only clean up at the start of the command |
…ight trigger login)
I'll merge this first thing tomorrow and do more testing, which will include #662 |
(this is based on the WIP PoC for the aio app package command)
How Has This Been Tested?
Types of changes
Checklist: