Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle errors without stack traces when using --verbose #796

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

MichaelGoberling
Copy link
Contributor

@MichaelGoberling MichaelGoberling commented Apr 24, 2024

Description

Related Issue

fixes #795

Motivation and Context

How Has This Been Tested?

npm run test, locally linked plugin

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MichaelGoberling MichaelGoberling changed the title Fix verbose stack typeerror fix: handle errors without stack traces when using --verbose Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d1741cf) to head (3a8e0fa).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #796   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3241      3241           
  Branches       617       617           
=========================================
  Hits          3241      3241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelGoberling MichaelGoberling merged commit e9d4bf8 into master Apr 25, 2024
8 checks passed
@MichaelGoberling MichaelGoberling deleted the fix-verbose-stack-typeerror branch April 25, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using verbose flag sometimes results in TypeError
3 participants