-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(variables): support service-specific pipeline variables. fixes #686 #687
Conversation
99d8e07
to
1cddffa
Compare
Code and test ok |
4934ac6
to
9a1db2b
Compare
To change:
|
2f5e5c4
to
df18d39
Compare
590b541
to
02c1443
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 64 64
Lines 1536 1542 +6
Branches 214 214
=======================================
+ Hits 1531 1537 +6
Misses 5 5 ☔ View full report in Codecov by Sentry. |
de351a2
to
0546fd3
Compare
0546fd3
to
b1001e9
Compare
I have not tested, but codewise i don't notice anything off. Why was the node version update needed? |
The readme requires some updates still. The authentication paragraph still only documents the JWT based one. |
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Supports service for pipeline variables was added in the CLI.
Related Issue
#686
Motivation and Context
The pipeline variable API now supports service for pipeline variables and that should be available in the CLI.
How Has This Been Tested?
Unit tests
Types of changes
Checklist: