Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(variables): support service-specific pipeline variables. fixes #686 #687

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

sii41383
Copy link
Member

@sii41383 sii41383 commented Mar 21, 2024

Description

Supports service for pipeline variables was added in the CLI.

Related Issue

#686

Motivation and Context

The pipeline variable API now supports service for pipeline variables and that should be available in the CLI.

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sii41383 sii41383 force-pushed the issues/pipeline-variables-service branch 4 times, most recently from 99d8e07 to 1cddffa Compare March 22, 2024 11:29
@proactivebit
Copy link
Contributor

Code and test ok

proactivebit
proactivebit previously approved these changes Mar 22, 2024
@sii41383 sii41383 force-pushed the issues/pipeline-variables-service branch 3 times, most recently from 4934ac6 to 9a1db2b Compare March 22, 2024 13:26
@proactivebit
Copy link
Contributor

To change:

  • Change in readme min required node version to 16,
  • Set version to 4.2.0,
  • Add changelog info

@sii41383 sii41383 force-pushed the issues/pipeline-variables-service branch 8 times, most recently from 2f5e5c4 to df18d39 Compare March 22, 2024 15:07
@proactivebit proactivebit force-pushed the issues/pipeline-variables-service branch 2 times, most recently from 590b541 to 02c1443 Compare March 25, 2024 09:55
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (47fbbf9) to head (b1001e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          64       64           
  Lines        1536     1542    +6     
  Branches      214      214           
=======================================
+ Hits         1531     1537    +6     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@proactivebit proactivebit force-pushed the issues/pipeline-variables-service branch 2 times, most recently from de351a2 to 0546fd3 Compare March 25, 2024 10:58
@proactivebit proactivebit force-pushed the issues/pipeline-variables-service branch from 0546fd3 to b1001e9 Compare March 25, 2024 11:36
@anastasiapintilie
Copy link
Contributor

I have not tested, but codewise i don't notice anything off. Why was the node version update needed?

@proactivebit
Copy link
Contributor

I have not tested, but codewise i don't notice anything off. Why was the node version update needed?

Dependencies has changed and they are using now code from javascript 16. In other case we will get error when doing npm test as shown bellow.
image

@proactivebit proactivebit merged commit 30b3d18 into main Apr 8, 2024
8 checks passed
@kwin
Copy link
Contributor

kwin commented Apr 13, 2024

The readme requires some updates still. The authentication paragraph still only documents the JWT based one.

Copy link

github-actions bot commented May 8, 2024

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants