Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYO creds related issue #66

Merged
merged 10 commits into from
Oct 5, 2020
Merged

BYO creds related issue #66

merged 10 commits into from
Oct 5, 2020

Commits on Sep 24, 2020

  1. Merge pull request #4 from adobe/master 

    Sync with Master
    @sandeep-paliwal
    sandeep-paliwal authored Sep 24, 2020
    Configuration menu
    Copy the full SHA
    45d86b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Code refactoring to abstract TVM behaviour from Files impl 

    Fixed issue with BYO creds
Fixed issue with presign URL feature not working with BYO creds
    @sandeep-paliwal
    sandeep-paliwal committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    7fed333 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Made changes as per review comments

    @sandeep-paliwal
    sandeep-paliwal committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    b2131a4 View commit details
    Browse the repository at this point in the history

  2. added tests

    @sandeep-paliwal
    sandeep-paliwal committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    48128e4 View commit details
    Browse the repository at this point in the history

  3. support hostName in BYO credentials 

    Added tests
    @sandeep-paliwal
    sandeep-paliwal committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    b406e00 View commit details
    Browse the repository at this point in the history

  4. Throw error in case of sas byo creds 

    Updated doc
fixed tests for above change
    @sandeep-paliwal
    sandeep-paliwal committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    3b23711 View commit details
    Browse the repository at this point in the history

  5. minor fix for byo sas creds

    @sandeep-paliwal
    sandeep-paliwal committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    1b7053d View commit details
    Browse the repository at this point in the history

  6. closed review comments

    @sandeep-paliwal
    sandeep-paliwal committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    17de909 View commit details
    Browse the repository at this point in the history

  7. removed unnecessary tests

    @sandeep-paliwal
    sandeep-paliwal committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    ff2e6b8 View commit details
    Browse the repository at this point in the history

  8. added jsdoc comment

    @sandeep-paliwal
    sandeep-paliwal committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    12ebe86 View commit details
    Browse the repository at this point in the history