-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ACNA-2585 - library configuration & networking #138
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 165 208 +43
Branches 29 44 +15
=========================================
+ Hits 165 208 +43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommendations,
- validate regions: oneOf amer, apac and emea
- default region: amer
wdyt?
SGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! (just added one small comment regarding testing)
…r local e2e testing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue to not change the way we expose the expiration to users in the library (keep iso), wdyt?
makes sense, ISO string is unambiguous, and better, I think |
How Has This Been Tested?
Types of changes
Checklist: