Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dockerize e2e tests #142

Merged
merged 5 commits into from
Mar 18, 2024
Merged

feat: dockerize e2e tests #142

merged 5 commits into from
Mar 18, 2024

Conversation

shazron
Copy link
Member

@shazron shazron commented Mar 14, 2024

Motivation and Context

For ease of e2e testing, for canary deploys.

How Has This Been Tested?

  • create e2e/.env (see .env.example)
  • run the local server (see internal adp-storage-state repo, requires a modification to add the second test namespace)
  • npm run e2e (to verify it works first), then
  • run the e2e via docker (see e2e/e2e.md)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c24fc29) to head (8bc4c75).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          215       215           
  Branches        46        46           
=========================================
  Hits           215       215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron marked this pull request as ready for review March 14, 2024 12:53
@shazron shazron requested a review from moritzraho March 14, 2024 12:55
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@shazron shazron merged commit 22a3824 into main Mar 18, 2024
8 checks passed
@shazron shazron deleted the docker-e2e branch March 18, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants