Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list keys #164

Merged
merged 6 commits into from
Jun 17, 2024
Merged

feat: list keys #164

merged 6 commits into from
Jun 17, 2024

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Jun 11, 2024

Description

expose an AsyncIterator:

const allKeys = []
for await (const { keys } of state.list({ match: 'abc*', countHint: 100 })) {
  allKeys.push(...keys)
}
  • match to filter keys, it supports * glob-style patterns, i.e. a*c, *c, a* would all match an abc key.
  • countHint to control the number of returned elements per iteration, note that this is not an exact counter and the service may return more and in rare cases fewer elements. min: 100, max: 1000, default: 100.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f41cdeb) to head (b118ad9).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          218       247   +29     
  Branches        38        42    +4     
=========================================
+ Hits           218       247   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arjuncooliitr arjuncooliitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/AdobeState.js Outdated Show resolved Hide resolved
lib/AdobeState.js Outdated Show resolved Hide resolved
test/AdobeState.test.js Outdated Show resolved Hide resolved
test/AdobeState.test.js Show resolved Hide resolved
@moritzraho moritzraho merged commit fe75614 into main Jun 17, 2024
8 checks passed
@moritzraho moritzraho deleted the feat/list-keys branch June 17, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants