fix: infinite TTLs are not supported anymore, forward ttl=0 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 247 251 +4
Branches 42 43 +1
=========================================
+ Hits 247 251 +4 ☔ View full report in Codecov by Sentry. |
MichaelGoberling
approved these changes
Jun 19, 2024
shazron
approved these changes
Jun 19, 2024
| sdkDetails: { key, valueLength: value.length, options, errors } | ||
| })) | ||
| } | ||
| if (ttl !== undefined && (ttl < 0 || ttl > MAX_TTL_SECONDS)) { |
There was a problem hiding this comment.
too bad AJV validator can't have a min max :/
There was a problem hiding this comment.
yes AJV has a min max, but the error message is not nice...
AioCoreSDKError [AdobeStateLibError]: [AdobeStateLib:ERROR_BAD_ARGUMENT] WARNING: keyword 'minimum' was not handled for formatting: {
"instancePath": "/ttl",
"schemaPath": "#/properties/ttl/minimum",
"keyword": "minimum",
"params": {
"comparison": ">=",
"limit": 0
},
"message": "must be >= 0"
}
I wanted to make it clear that infinite ttls are not supported anymore!
There was a problem hiding this comment.
actually we can add the support in our code here, but maybe for next time:
Line 63 in 94e34ad
There was a problem hiding this comment.
great maybe next time, as this is a custom error anyways
moritzraho
force-pushed
the
fix/infinite-ttl
branch
from
a6c3b83
to
7a4e065
Compare
moritzraho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: