ACNA-961 | add cosmosDB 429 custom error handling #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 164 167 +3
Branches 32 33 +1
=========================================
+ Hits 164 167 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lib/StateStoreError.js
Outdated
| @@ -58,6 +59,7 @@ E('ERROR_BAD_ARGUMENT', '%s') | |||
| E('ERROR_NOT_IMPLEMENTED', 'method `%s` not implemented') | |||
| E('ERROR_BAD_CREDENTIALS', 'cannot access %s, make sure your credentials are valid') | |||
| E('ERROR_PAYLOAD_TOO_LARGE', 'key, value or request payload is too large') | |||
| E('ERROR_DB_RATE_LIMITED', 'db access requests rate limited') | |||
There was a problem hiding this comment.
We can change this to following
E('ERROR_REQUEST_RATE_TOO_HIGH', 'Request rate too high. Please retry after sometime.')
There was a problem hiding this comment.
Sure, this looks much better error code and message to be exposed to the user. I'll make the changes.
arjuncooliitr
requested review from
moritzraho,
sandeep-paliwal,
shazron,
amulyakashyap09,
MichaelGoberling and
purplecabbage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to wrap the internal cosmosDB 429 error (thrown when more RUs are consumed than provisioned) and throw documented customized error known by state lib.
Related Issue
#58
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: