-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parcel upgrade to 2.x release #158
Conversation
This is to mitigate security issues with `nth-check` and `postcss` packages.
consult with @Himavanth before this gets merged since .rc0 has breaking changes for us. |
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 163 163
Branches 40 40
=========================================
Hits 163 163 Continue to review full report at Codecov.
|
The 2.0 release introduces a breaking change where script tags are not considered as modules by default and hence will not allow imports or exports. It is documented here. https://v2.parceljs.org/blog/rc0/#classic-scripts-vs.-es-modules So user apps need to be changed from
to
This change should be considered a breaking change (thus a major version bump). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for identifying the particular use case where apps break.
Doing this on a major seems reasonable.
This is to mitigate security issues with
nth-check
,postcss
, andnode-forge
packages.Closes #163
Types of changes
Checklist: