Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parcel upgrade to 2.x release #158

Merged
merged 3 commits into from
May 13, 2022
Merged

fix: parcel upgrade to 2.x release #158

merged 3 commits into from
May 13, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 8, 2021

This is to mitigate security issues with nth-check, postcss, and node-forge packages.

Closes #163

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This is to mitigate security issues with `nth-check` and `postcss` packages.
@shazron
Copy link
Member Author

shazron commented Oct 8, 2021

consult with @Himavanth before this gets merged since .rc0 has breaking changes for us.

@shazron shazron requested a review from Himavanth October 8, 2021 03:42
@shazron shazron marked this pull request as draft October 8, 2021 03:42
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #158 (655d964) into master (697621e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          163       163           
  Branches        40        40           
=========================================
  Hits           163       163           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697621e...655d964. Read the comment docs.

@shazron shazron changed the title fix: parcel upgrade to .rc0 fix: parcel upgrade to 2.x release Apr 25, 2022
@shazron
Copy link
Member Author

shazron commented Apr 26, 2022

The 2.0 release introduces a breaking change where script tags are not considered as modules by default and hence will not allow imports or exports.

It is documented here. https://v2.parceljs.org/blog/rc0/#classic-scripts-vs.-es-modules

So user apps need to be changed from

<script src="./src/index.js" async="true"></script>

to

<script src="./src/index.js" async="true" type="module"></script>

This change should be considered a breaking change (thus a major version bump).

@shazron shazron marked this pull request as ready for review April 26, 2022 08:06
Copy link
Member

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying the particular use case where apps break.
Doing this on a major seems reasonable.

@shazron shazron merged commit fec5c3a into master May 13, 2022
@shazron shazron deleted the parcel-upgrade branch May 13, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breaking change: update to parcel@2 release
2 participants