Added "defaultPersonalizationEnabled" option to the sendEvent command to control requesting the page-wide scope and default surface #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterworks
approved these changes
Jul 17, 2023
jfkhoury
reviewed
Jul 22, 2023
| @@ -34,7 +34,8 @@ export default ({ options }) => { | |||
| }), | |||
| datasetId: string(), | |||
| mergeId: string(), | |||
| edgeConfigOverrides: validateConfigOverride | |||
| edgeConfigOverrides: validateConfigOverride, | |||
| initializePersonalization: boolean() | |||
There was a problem hiding this comment.
Is it more like disablePersonalization?
There was a problem hiding this comment.
yes, it will disable personalization for that event. But I would like us to take an approach that can be extensible in future.
We have the personalization object as an option to sendEvent command, we could move the cache initialization flag there, which is on by default for the first event and can be disabled/enabled per event.
ninaceban
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
@jonsnyder looks good with one comment: should move the flag inside personalization object.
jonsnyder
changed the title
jonsnyder
changed the title
jonsnyder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an option to the sendEvent command called "initializePersonalization". This option controls whether or not the default scope is initialized and whether or not to request the default surface.
I'm not really happy with this naming. I'm open to different names.
Related Issue
https://jira.corp.adobe.com/browse/PDCL-10626?
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: