-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fetch pr comments #1061
Misc fetch pr comments #1061
Conversation
PropositionEventType.DISPLAY | ||
); | ||
const decisionsMeta = flatMap(decisionsMetas, dms => dms); | ||
if (decisionsMeta.length > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use isNonEmptyArray
util here
governing permissions and limitations under the License. | ||
*/ | ||
|
||
export default window => url => window.location.replace(url); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be reused in in-browser messages
feature when treating positive onClick
consequence.
cc: @shandilya3 @jasonwaters
Description
This fixes a number of issues found in the large Fetch PR:
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: