Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fetch pr comments #1061

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Misc fetch pr comments #1061

merged 6 commits into from
Oct 23, 2023

Conversation

jonsnyder
Copy link
Contributor

@jonsnyder jonsnyder commented Oct 18, 2023

Description

This fixes a number of issues found in the large Fetch PR:

  • Extract redirect into its own util
  • Use a collect call when sending a display notification for a redirect
  • Move check for empty set of display notifications
  • Remove extra condition

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

PropositionEventType.DISPLAY
);
const decisionsMeta = flatMap(decisionsMetas, dms => dms);
if (decisionsMeta.length > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use isNonEmptyArray util here

governing permissions and limitations under the License.
*/

export default window => url => window.location.replace(url);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be reused in in-browser messages feature when treating positive onClick consequence.
cc: @shandilya3 @jasonwaters

@jonsnyder jonsnyder merged commit 33288d6 into main Oct 23, 2023
1 check passed
@jonsnyder jonsnyder deleted the miscFetchPRComments branch October 23, 2023 17:53
@jonsnyder jonsnyder added the ignore-for-release Do not include this PR in release notes label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants