Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix applyResponse functional test #1085

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix applyResponse functional test #1085

merged 1 commit into from
Jan 5, 2024

Conversation

shandilya3
Copy link
Collaborator

@shandilya3 shandilya3 commented Nov 15, 2023

Description

Ticket (https://jira.corp.adobe.com/browse/PDCL-11302)

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

Copy link
Contributor

@jonsnyder jonsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

{
key: "at_qa_mode",
value:
'{"token":"xFgbBknmbC1SwBodlfVLxgF5KVrsCNsY4g8dvHk0wA0","listedActivitiesOnly":true,"previewIndexes":[{"activityIndex":1,"experienceIndex":1}]}'
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining why we need to have the qa_mode cookie for the test?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy messaged me about it. She isn't sure why, but the test fails without it ("Identity was not set properly" error message 🙄 ).

{
key: "at_qa_mode",
value:
'{"token":"xFgbBknmbC1SwBodlfVLxgF5KVrsCNsY4g8dvHk0wA0","listedActivitiesOnly":true,"previewIndexes":[{"activityIndex":1,"experienceIndex":1}]}'
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy messaged me about it. She isn't sure why, but the test fails without it ("Identity was not set properly" error message 🙄 ).

@shandilya3 shandilya3 merged commit 6a31553 into main Jan 5, 2024
2 of 3 checks passed
@shandilya3 shandilya3 deleted the fixApplyResponseTest branch January 5, 2024 18:32
@jonsnyder jonsnyder added the ignore-for-release Do not include this PR in release notes label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants