-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Adobe Journey Optimizer content cards in subscribeRulesetItems #1125
Conversation
…n executeAction method
# Conflicts: # src/core/createEventManager.js # test/functional/specs/Visitor/C35448.js
# Conflicts: # src/core/createEventManager.js
# Conflicts: # src/components/DecisioningEngine/index.js # src/components/DecisioningEngine/utils.js # src/utils/debounce.js # test/unit/specs/components/DecisioningEngine/createContextProvider.spec.js # test/unit/specs/components/DecisioningEngine/utils.spec.js
# Conflicts: # sandbox/src/components/InAppMessagesDemo/InAppMessages.js # src/components/DecisioningEngine/createSubscribeRulesetItems.js # src/components/DecisioningEngine/index.js # src/components/DecisioningEngine/utils.js # src/components/Personalization/createComponent.js # src/components/Personalization/createOnDecisionHandler.js # src/components/Personalization/createPersonalizationDetails.js # src/components/Personalization/index.js # src/core/config/createCoreConfigs.js # test/functional/helpers/createAlloyProxy.js # test/unit/specs/components/DecisioningEngine/createSubscribeRulesetItems.spec.js # test/unit/specs/components/Personalization/createComponent.spec.js # test/unit/specs/components/Personalization/createModules.spec.js # test/unit/specs/components/Personalization/createNotificationHandler.spec.js # test/unit/specs/components/Personalization/createOnDecisionHandler.spec.js # test/unit/specs/components/Personalization/createPersonalizationDetails.spec.js # test/unit/specs/components/Personalization/dom-actions/createRedirect.spec.js # test/unit/specs/components/Personalization/topLevel/buildAlloy.js # test/unit/specs/components/Personalization/topLevel/cartViewDecisions.spec.js # test/unit/specs/components/Personalization/topLevel/mergedMetricDecisions.spec.js # test/unit/specs/components/Personalization/topLevel/mixedPropositions.spec.js # test/unit/specs/components/Personalization/topLevel/pageWideDecisionsWithDomActionSchemaItems.spec.js # test/unit/specs/components/Personalization/topLevel/pageWideScopeDecisions.spec.js # test/unit/specs/components/Personalization/topLevel/pageWideScopeDecisionsWithoutDomActionSchemaItems.spec.js # test/unit/specs/components/Personalization/topLevel/productsViewDecisions.spec.js # test/unit/specs/components/Personalization/topLevel/redirectPageWideScopeDecision.spec.js # test/unit/specs/components/Personalization/topLevel/scopesFoo1Foo2Decisions.spec.js # test/unit/specs/utils/assignConcatArrayValues.spec.js # test/unit/specs/utils/createSubscription.spec.js
Hi Jason, is the new command |
They have some similarities, but
The |
Here is a comparison of Using
|
# Conflicts: # src/components/Personalization/index.js
---->>> There are none! 🏆 This is my favorite! 😆 @jasonwaters The team will be reviewing this feature starting Monday. |
This PR has been updated:
Todo:
cc: @ninaceban @jfkhoury |
@@ -35,6 +35,7 @@ export default ({ options }) => { | |||
data: objectOf({}), | |||
documentUnloading: boolean(), | |||
renderDecisions: boolean(), | |||
decisionContext: objectOf({}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide more details why this is needed?
New options related to personalization should go under personalization
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, good catch. it's actually already in personalization, looks like we just forgot to remove it from top level. i'll remove it
@@ -23,8 +23,8 @@ export const REDIRECT_ITEM = | |||
|
|||
export const MESSAGE_IN_APP = | |||
"https://ns.adobe.com/personalization/message/in-app"; | |||
export const MESSAGE_FEED_ITEM = | |||
"https://ns.adobe.com/personalization/message/feed-item"; | |||
export const MESSAGE_CONTENT_CARD = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Message Feed Item
was renamed to Content Card
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, "Feed item" isn't a thing anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working with Nina! This looks great.
- Can you update the description of this PR to reflect the final state of the API?
- I see that message-feed-item is renamed to content-card. Is this backward compatible? Will customers need to do anything when they upgrade Web SDK?
# Conflicts: # src/components/DecisioningEngine/createSubscribeRulesetItems.js
Description
This PR adds support for content-cards to alloy. A "content card" campaign can be created in AJO. Each content card is assigned a surface. That surface is then used in the web sdk to subscribe to content cards. Rendering content cards is an exercise left to the customer. see the alloy-samples sample for more details about usage and how-to.
Product and Technical Requirements
Types of changes