Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue with incorrect AWS quotas calculation and moved docs to wiki #44

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

sparshev
Copy link
Collaborator

Found that Quotas on AWS are actually per vCPU, not per instance (those quotas names...) so changed the way it's calculated and improved the types management btw. Also moved the host docs to wiki.

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev added the bug Something isn't working label Feb 23, 2023
@sparshev sparshev self-assigned this Feb 23, 2023
@sparshev sparshev merged commit c1baca2 into main Feb 23, 2023
@sparshev sparshev deleted the aws_quota_fix_docs_moved branch February 23, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant