Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add patch version number in go.mod (X.Y => X.Y.Z) #68

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add patch version number in go.mod (X.Y => X.Y.Z) #68

merged 1 commit into from
Jun 4, 2024

Conversation

svenevs
Copy link
Collaborator

@svenevs svenevs commented May 15, 2024

Before Go 1.21, the initial release of a Go toolchain was
version 1.N, not 1.N.0, so for N < 21, the ordering is
adjusted to place 1.N after the release candidates.

https://go.dev/doc/toolchain#version

Go changed its versioning scheme in 1.21 from <major>.<minor> to <major>.<minor>.<patch>. CodeQL analysis flags this stating the lack of a patch number "may cause some go commands to fail."

Motivation and Context

CodeQL Analysis warns that some tooling may break without the patch number.

How Has This Been Tested?

It has not been; other than CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

svenevs
svenevs commented May 15, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@svenevs svenevs force-pushed the fix/go_mod_version branch 2 times, most recently from ba05ebe to 8c7da5f Compare May 15, 2024 22:02
@svenevs svenevs requested a review from sparshev May 15, 2024 22:10
sparshev
sparshev approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@sparshev sparshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What to say - LGTM

@sparshev sparshev added the enhancement New feature or request label May 16, 2024
@svenevs
Add patch version number in go.mod (X.Y => X.Y.Z)
c5d88de 
> Before Go 1.21, the initial release of a Go toolchain was
> version 1.N, not 1.N.0, so for N < 21, the ordering is
> adjusted to place 1.N after the release candidates.
>
> https://go.dev/doc/toolchain#version

Go changed its versioning scheme in 1.21 from `<major>.<minor>`
to `<major>.<minor>.<patch>`.  CodeQL analysis flags this
stating the lack of a patch number "may cause some `go` commands
to fail."
@svenevs svenevs merged commit a533e9e into main Jun 4, 2024
5 checks passed
@svenevs svenevs deleted the fix/go_mod_version branch June 4, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparshev sparshev sparshev approved these changes

Assignees

@svenevs svenevs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenevs @sparshev