Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TaskImage for AWS and an ability to use asterisk in image #74

Merged
merged 12 commits into from
Aug 6, 2024

Conversation

sparshev
Copy link
Collaborator

@sparshev sparshev commented Jul 23, 2024

The change adds an ability to request Aquarium to prepare Image just like Snapshot before. This should help with automated building of the images with embedded caches.

Features:

  • Encryption (re-encryption) - so even if you using not encrypted images as a base - the produced one will be encrypted
  • Latest image by the name with asterisk - actually AWS feature, but now logic tries to find the latest image if there is multiple of them in the return.

Other changes:

  • Fixed a couple of issues with openapi spec that failed the jenkins plugin build and added openapi spec yaml validation to CI.
  • Switched to the newest version of openapi-codegen. Also tried ogen and it could solve some issues with code generation, but needs a major rewrite to use it (Try to use ogen for code generation #75).
  • Added new API call to get tasks by ID - that helps to wait and find out how the task completed and what's the image name/id we've got.
  • Added more logging to tasks to keep track of their execution.
  • Made sure NodeFilter field in Resources will not return null and just empty list as described in spec.
  • Small fix to not print timestamps in debug mode if we don't need timestamps.

Related Issue

fixes: #73

Motivation and Context

Since caching in snapshots is a slowpoke, it's the easiest way to get some speed.

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev added the enhancement New feature or request label Jul 23, 2024
@sparshev sparshev self-assigned this Jul 23, 2024
@sparshev sparshev merged commit 557e014 into main Aug 6, 2024
6 checks passed
@sparshev sparshev deleted the AF-73 branch August 6, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS: Create image AMI's task
1 participant