Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASSETS-20895 remove rendition data from action results #202

Merged
merged 2 commits into from
Mar 28, 2023
Merged

ASSETS-20895 remove rendition data from action results #202

merged 2 commits into from
Mar 28, 2023

Conversation

pheenomenon
Copy link
Contributor

@pheenomenon pheenomenon commented Mar 23, 2023 •
edited
Loading

For https://jira.corp.adobe.com/browse/ASSETS-20895 Minimize activation response size of workers (COGS impact)
For workers using sdk: removed rendition and source data from activation results.
related pipeline pr

Result before code changes:
image

Result after code changes:
image

@codecov
Copy link

codecov bot commented Mar 23, 2023 •
edited
Loading

Codecov Report

Merging #202 (62ca005) into master (6a38616) will decrease coverage by 0.36%.
The diff coverage is n/a.

❗ Current head 62ca005 differs from pull request most recent head 3ec6fae. Consider uploading reports for the commit 3ec6fae to get more accurate results

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   59.22%   58.86%   -0.36%     
==========================================
  Files          11       11              
  Lines         802      795       -7     
==========================================
- Hits          475      468       -7     
  Misses        327      327
Impacted Files Coverage Δ
lib/worker.js 85.32% <ø> (-0.46%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pheenomenon
Copy link
Contributor Author

dependent-module-tests are failing. which I am looking more into, but are unrelated.

@pheenomenon pheenomenon mentioned this pull request Mar 27, 2023
Merged
tmathern
tmathern reviewed Mar 27, 2023
View reviewed changes
lib/worker.js

const result = {
requestId: this.params.requestId,
metrics: this.activationMetrics
requestId: this.params.requestId
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing metrics may have impacts on some unit/integration tests, as I'm not sure we don't use getResult to check those too. But tests will tell!

@pheenomenon
Copy link
Contributor Author

verified that dependent-test failure not related to this change.

@pheenomenon pheenomenon merged commit cfb3aa9 into master Mar 28, 2023
@adobe-bot
Copy link

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pheenomenon pheenomenon deleted the ASSETS-20895 branch March 28, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmathern tmathern tmathern approved these changes

@tcallsen tcallsen Awaiting requested review from tcallsen

@badvision badvision Awaiting requested review from badvision

@sudheendrakatikar sudheendrakatikar Awaiting requested review from sudheendrakatikar

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pheenomenon @adobe-bot @tmathern