This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
feat: chunked index #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
I have edited the description with the creativity working topic. |
|
That's why I tried to explain with adobe/business-website#131 (comment). My initial approach did not have this problem (only filter until you find 12). Yes, you might need to fetch the next chunk but you cannot avoid this case. |
kptdobe
approved these changes
Nov 7, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:
#38
initial support for chunked index...
compare:
https://chunked-index--blog--adobe.hlx.live/
https://chunked-index--blog--adobe.hlx.live/en/topics/creativity
vs.
https://main--blog--adobe.hlx.live/
https://main--blog--adobe.hlx.live/en/topics/creativity
with chunk size set at
500i am getting the following on throttledhaving said that, the inner loop for the filtering is considerably more expensive, which is definitely a problem especially with respect to the blocking time over 50ms. as in the current index architecture this loop has to run through up to 13k items, i think we should consider optimizing the inner most loop to be faster.
i wasn't able to find a topic page or an author page to make sure that the filtering actually works, so if @kptdobe could point me somewhere i am happy to take a look.