-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
update new strings
@@ -268,4 +289,13 @@ define({ | |||
"BASEURL_ERROR_HASH_DISALLOWED" : "L'URL di base non può contenere hash come \"{0}\".", | |||
"BASEURL_ERROR_INVALID_CHAR" : "I caratteri speciali come '{0}' devono essere %-encodate.", | |||
"BASEURL_ERROR_UNKOWN_ERROR" : "Trovato un carattere sconosciuto durante il parsing della URL di base" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comma on this line is causing the JSHint errors on the travis-ci build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I fix that? I have to change in my forked repo or what? (sorry, I'm new @ github 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the change locally, then push the changes back to your repo.
# assuming your at the top of the brackets directory
git add src/src/nls/it/strings.js
git commit -m "add missing comma"
git push origin master
Github will detect a new commit and display it here.
Iniital review complete. |
Sorry for the delay and the consequent exclusion of this PR from Sprint 21 |
Looks good. Merging. |
Updated italian translation
updated new strings