Fix issue #3556: Consolidate link handling code #4718
Conversation
ghost
assigned 
|
Nominating sprint 30 |
|
I need to reconcile this with #4695. Just learned about this from @peterflynn. |
|
The link handling code is inside Peter's fix. I figured that would be the best place to handle it. Everything is together now. |
|
@TomMalbran can you merge with master? Thanks! |
|
This will be harder to merge... but will do it soon :) |
|
@jasonsanjose Done |
| @@ -293,11 +293,11 @@ define({ | |||
| "ABOUT" : "O aplikaci", | |||
| "CLOSE" : "Zavřít", | |||
| "ABOUT_TEXT_LINE1" : "sprint {VERSION_MINOR} {BUILD_TYPE} {VERSION}", | |||
| "ABOUT_TEXT_LINE3" : "Oznámení, podmínky týkající se software třetích stran jsou umístěny na <a href='#' class='clickable-link' data-href='{ADOBE_THIRD_PARTY}'>http://www.adobe.com/go/thirdparty/</a> a začleněny prostřednictvím odkazu zde.", | |||
| "ABOUT_TEXT_LINE4" : "Dokumentace a zdrojový kód na <a href='#' class='clickable-link' data-href='https://github.com/adobe/brackets/'>https://github.com/adobe/brackets/</a>.", | |||
| "ABOUT_TEXT_LINE3" : "Oznámení, podmínky týkající se software třetích stran jsou umístěny na <a href='http://www.adobe.com/go/thirdparty/'>http://www.adobe.com/go/thirdparty/</a> a začleněny prostřednictvím odkazu zde.", | |||
There was a problem hiding this comment.
<a href='http://www.adobe.com/go/thirdparty/'> should be <a href='{ADOBE_THIRD_PARTY}'>
|
Initial review complete. Sorry for the mixup on #4695. I see that these don't overlap how I thought they might have. Nice cleanup. |
|
@jasonsanjose Fixed all the urls issues. I had to create some new urls files and added several missing languages in |
|
Looks great. Thanks @TomMalbran. Merging. |
Fix issue #3556: Consolidate link handling code
This is a fix for issue #3556. I added the link handling code to the new code that prevents the links to do the default behavior and removed every other handling code. I also updated all the links to use the href for the url.