This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Adds a few more colors and changes cursor back to beam #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dresses issues 86 and 87
This was referenced Jan 16, 2012
ghost
assigned 
|
Assigned to @peterflynn because he filed issue #87 |
| @accent-link: @content-color; | ||
| @accent-quote: @bc-blue; | ||
| @accent-hr: @bc-orange; | ||
| @accent-link: @bc-violet; |
There was a problem hiding this comment.
Do you know where accent-hr and accent-link are actually used? I don't see them on <hr> or <a> tags (nor on the value of href/src attributes).
There was a problem hiding this comment.
No, I don't. :-) I thought the same thing.
But, if it comes up, they'll be colored orange and violet respectively.
I'm sure these aren't the final colors we'll stick with once we get an XD person on board. I just wanted to add more color so it was easier to tell that the mode switching was working.
|
Looks fine to me! The two AWOL highlight colors don't seem that important, so I'll just go ahead and merge now... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterflynn
Addresses issues #86 and #87.