This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
CIF-421 - Magento searchProducts action does not support multiple parameters #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameters - added support for multiple search parameter values for a given filter
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 97.43% 97.44% +0.01%
==========================================
Files 50 50
Lines 1013 1019 +6
==========================================
+ Hits 987 993 +6
Misses 26 26
Continue to review full report at Codecov.
|
cjelger
requested review from
herzog31,
masodu,
hasnarobert,
mhaack,
dplaton and
LSantha
dplaton
approved these changes
Aug 22, 2018
…ameters - minor change
mhaack
approved these changes
Aug 22, 2018
| @@ -144,6 +144,25 @@ describe('magento searchProducts', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('returns a valid response with 2 SKUs', function() { | |||
There was a problem hiding this comment.
Should we add an additional test with more complex filter? Like 2 sku + 1 category and 2 sku + text = shirt.
There was a problem hiding this comment.
I added an extra test for sku + text, note that in this case the search performs an AND operation.
hasnarobert
changed the title
…ameters - added an extra IT for a combined search
hasnarobert
approved these changes
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multiple values for search parameters.
Description
Adds support for multiple values for search parameters.
Related Issue
CIF-421
Motivation and Context
See CIF-421
How Has This Been Tested?
Added unit + integration test.
Screenshots (if appropriate):
Types of changes
Checklist: