fix(SITES-2874 Accessibility) - Visual list is not marked up as list.

[StoianLucian]

Ticket: SITES-2874

Added role list and listitem to the required elements

[StoianLucian]

after applying the change, axe devTools can't identify the problem that appears in the failing build

[StoianLucian]

[petcud]

Please fix the curly braces.
For the complexity warning, if you cannot simplify the complexity, and it's code that wasn't introduced by you, it might generate a code smell report but should be fine to merge.

[petcud]

try the aria role 'list' instead of the 'listitem'

[ens84646]

Please fix the curly braces. For the complexity warning, if you cannot simplify the complexity, and it's code that wasn't introduced by you, it might generate a code smell report but should be fine to merge.

@petcud check warnings not related to the actual change, should we resolve this reports for every PR created as long as it were not generated by this PR?

[StoianLucian]

Hi @petcud the role "list" is only to be use for the wrapper of the list and the role "listitem" is to be used for the each element from inside the wrapper as suggested in the ticket and in the accessibility guides https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listitem_role

[StoianLucian]

@Pareesh is there anything else we should do regarding this ticket? If not could you merge it?