Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include coverage for all source files #58

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Include coverage for all source files #58

merged 3 commits into from
Jun 10, 2024

Conversation

bosschaert
Copy link
Contributor

Description

Previously coverage figures were only on source files touched by unit tests, which meant that if you added tests to a previously untested sourcefile, it would typically bring the overall coverage down, unless that new file was immediately close to 100% covered.

This change computes coverage figures on all source files, which is more truthful.

It will seriously bring the coverage figure down, but the new coverage figure is the correct one.

Also updated .nycrc.json to accept the current figure as the minimum one.

Types of changes

A build system fix. No change to the actual product code.

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Not just ones that are touched by unit tests.
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.08%. Comparing base (48867b1) to head (2cc1d06).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
- Coverage   82.72%   47.08%   -35.64%     
===========================================
  Files          14       35       +21     
  Lines         909     1597      +688     
===========================================
  Hits          752      752               
- Misses        157      845      +688     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
.nycrc.json Show resolved Hide resolved
bosschaert and others added 2 commits June 7, 2024 17:26
Co-authored-by: Bryan Stopp <bstopp@users.noreply.github.com>
@bosschaert bosschaert merged commit 514b998 into main Jun 10, 2024
4 of 5 checks passed
@bosschaert bosschaert deleted the coverall branch June 10, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants